Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1349463003: Revert of Remove the 'gyp_config' concept from MB. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews, nodir, Bons, Zhen Wang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove the 'gyp_config' concept from MB. (patchset #2 id:20001 of https://codereview.chromium.org/1348463002/ ) Reason for revert: Looks like the output_dir part of this is wrong: ... http://build.chromium.org/p/chromium.perf/builders/Win%20x64%20Builder/builds/17237/steps/generate_build_files/logs/stdio Original issue's description: > Remove the 'gyp_config' concept from MB. > > Previously MB would try to ensure that the build directory > passed to it matched the expected gyp configuration for the bot > (i.e. that we would not pass "//out/Debug" as a path for a > release bot). > > Making this work correctly was awkward for the Win x64 bots > (which use Release_x64 instead of Release), and it's not clear > that this check would ever actually catch a real problem. > > So, this patch deletes all of the 'gyp_config' logic instead > and simplifies things. > > TBR=scottmg@chromium.org > BUG=481692 > > Committed: https://crrev.com/fae80e312dba6818315f4f8f0c3a1d85f6f4f9fb > Cr-Commit-Position: refs/heads/master@{#349043} TBR=scottmg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=481692 Committed: https://crrev.com/221341cbdcef0b6efd425ae401ab38a5588c3531 Cr-Commit-Position: refs/heads/master@{#349046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -12 lines) Patch
M tools/mb/docs/user_guide.md View 3 chunks +5 lines, -2 lines 0 comments Download
M tools/mb/mb.py View 7 chunks +30 lines, -9 lines 0 comments Download
M tools/mb/mb_config.pyl View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/mb/mb_unittest.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
Created Revert of Remove the 'gyp_config' concept from MB.
5 years, 3 months ago (2015-09-16 00:23:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349463003/1
5 years, 3 months ago (2015-09-16 00:24:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 00:24:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/221341cbdcef0b6efd425ae401ab38a5588c3531 Cr-Commit-Position: refs/heads/master@{#349046}
5 years, 3 months ago (2015-09-16 00:25:38 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:51:42 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/221341cbdcef0b6efd425ae401ab38a5588c3531
Cr-Commit-Position: refs/heads/master@{#349046}

Powered by Google App Engine
This is Rietveld 408576698