Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 134943002: Fix memory leak in tests. (Closed)

Created:
6 years, 11 months ago by pwestin
Modified:
6 years, 11 months ago
Reviewers:
mikhal1
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix memory leak in tests. Fixes 2 memory leaks related to GPU accelerated video encoding. The TaskRunner must run one final time to clean the memory. BUG=333142 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M media/cast/video_sender/external_video_encoder_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M media/cast/video_sender/video_sender_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pwestin
please review ASAP
6 years, 11 months ago (2014-01-10 22:04:04 UTC) #1
mikhal1
lgtm
6 years, 11 months ago (2014-01-10 22:05:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pwestin@google.com/134943002/1
6 years, 11 months ago (2014-01-10 22:07:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pwestin@google.com/134943002/1
6 years, 11 months ago (2014-01-10 23:54:33 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-12 02:53:08 UTC) #5
Message was sent while issue was closed.
Change committed as 244422

Powered by Google App Engine
This is Rietveld 408576698