Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1349403002: X87: [builtins] Unify the String constructor. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Unify the String constructor. port a3d6f6cce317dbe1d31079eb81e15e49f3fb687a (r30759). original commit message: Implement the String constructor completely as native builtin, avoiding the need to do gymnastics in JavaScript builtin to properly detect the no argument case (which is different from the undefined argument case) and also allowing to just tailcall through to ToString or SymbolDescriptiveString for the common case. Also the JavaScript builtin was misleading since the case for construct call was unused, but could be triggered in a wrong way once we support tail calls from constructor functions. This refactoring allows us to properly implement subclassing for String builtins, once we have the correct initial_map on derived classes (it's merely a matter of using NewTarget instead of the target register now). This introduces a new %SymbolDescriptiveString runtime entry, which is also used by Symbol.toString() now. BUG= Committed: https://crrev.com/55da29f443b6f2cd45ff87a1f2841842f1452971 Cr-Commit-Position: refs/heads/master@{#30826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -1 line) Patch
M src/x87/builtins-x87.cc View 1 chunk +62 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-18 07:16:36 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-18 11:21:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349403002/1
5 years, 3 months ago (2015-09-18 11:21:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 11:46:22 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 11:46:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55da29f443b6f2cd45ff87a1f2841842f1452971
Cr-Commit-Position: refs/heads/master@{#30826}

Powered by Google App Engine
This is Rietveld 408576698