Issue 1349343004: git-cl-try: fix "revision" property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1349343004: git-cl-try: fix "revision" property (Closed)

Created:
5 years, 3 months ago by nodir

Modified:
5 years, 3 months ago

Reviewers:
tandrii(chromium)

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

git-cl-try: fix "revision" property The revision property must be a part of `changes`, per https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/master/buildbucket/README.md R=tandrii@chromium.org BUG=534315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296790

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	git_cl.py	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349343004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349343004/20001

5 years, 3 months ago (2015-09-21 15:49:38 UTC) #4

commit-bot: I haz the power

5 years, 3 months ago (2015-09-21 15:51:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296790

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages