Introduce aliases and regex in submit_try

Introduce aliases and regex in submit_try.

Adding the aliases 'compile' and 'cq'. Also adding a alias 'regex' that prompts the user for a regex, displays results and prompts again for confirmation.

Created to fix the feature request https://code.google.com/p/skia/issues/detail?id=1207 : replace hard-coded trybot lists with automated filtering.

(SkipBuildbotRuns)
Committed: https://code.google.com/p/skia/source/detail?r=8569

[borenet, 2013-04-08 21:02:21]

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try
File tools/submit_try (right):

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode182
tools/submit_try:182: format_args = ['\n  '.join(trybots)] + ALL_ALIASES
I might put the aliases first, since the list of trybots will be long.

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode193
tools/submit_try:193: """ % tuple(format_args))
This seems like a strange way to do this, since the string to print makes the
assumption that format_args will be: (somelistoftrybots, "all", "compile", "cq",
"regex")

Why not just:

"....." % ('\n  '.join(trybots), ALL_BUILDERS, COMPILE_BUILDERS, CQ_BUILDERS,
REGEX)

?

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode210
tools/submit_try:210: using_bots = filter(lambda trybot: '_Compile_' in trybot,
trybots)
Is this faster than a list comprehension?

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode218
tools/submit_try:218: print '\n\nTrybots that match your regex:\n%s\n\n' %
'\n'.join(using_bots)
Nit: 80 chars.

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode286
tools/submit_try:286: trybots = RetrieveTrybotList(json_filename='builders')
Actually, now that we have the /json/trybots page, we can make this 'trybots'
right?

[rmistry, 2013-04-08 21:11:38]

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try
File tools/submit_try (right):

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode182
tools/submit_try:182: format_args = ['\n  '.join(trybots)] + ALL_ALIASES
On 2013/04/08 21:02:21, borenet wrote:
> I might put the aliases first, since the list of trybots will be long.

They have to be in the same order as required by the string below or did you
mean something else?

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode193
tools/submit_try:193: """ % tuple(format_args))
On 2013/04/08 21:02:21, borenet wrote:
> This seems like a strange way to do this, since the string to print makes the
> assumption that format_args will be: (somelistoftrybots, "all", "compile",
"cq",
> "regex")
> 
> Why not just:
> 
> "....." % ('\n  '.join(trybots), ALL_BUILDERS, COMPILE_BUILDERS, CQ_BUILDERS,
> REGEX)
> 
> ?

This is how I did it first but then I worried about people adding more aliases
and not updating documentation. This way if an alias is added and not documented
here then it will fail.
Though I dont have a strong preference either way.

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode210
tools/submit_try:210: using_bots = filter(lambda trybot: '_Compile_' in trybot,
trybots)
On 2013/04/08 21:02:21, borenet wrote:
> Is this faster than a list comprehension?

List comprehension is marginally faster but the performance difference is
negligible in this (and majority of other) cases. People who prefer one of the
two are divided in different camps in python, it all comes down to personal
preference.

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode218
tools/submit_try:218: print '\n\nTrybots that match your regex:\n%s\n\n' %
'\n'.join(using_bots)
On 2013/04/08 21:02:21, borenet wrote:
> Nit: 80 chars.

Done.

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode286
tools/submit_try:286: trybots = RetrieveTrybotList(json_filename='builders')
On 2013/04/08 21:02:21, borenet wrote:
> Actually, now that we have the /json/trybots page, we can make this 'trybots'
> right?

Yes right. Done.

[borenet, 2013-04-08 21:15:50]

LGTM

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try
File tools/submit_try (right):

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode182
tools/submit_try:182: format_args = ['\n  '.join(trybots)] + ALL_ALIASES
On 2013/04/08 21:11:38, rmistry wrote:
> On 2013/04/08 21:02:21, borenet wrote:
> > I might put the aliases first, since the list of trybots will be long.
> 
> They have to be in the same order as required by the string below or did you
> mean something else?

I wrote the comment before I really understood the code. Please ignore :)

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode193
tools/submit_try:193: """ % tuple(format_args))
On 2013/04/08 21:11:38, rmistry wrote:
> On 2013/04/08 21:02:21, borenet wrote:
> > This seems like a strange way to do this, since the string to print makes
the
> > assumption that format_args will be: (somelistoftrybots, "all", "compile",
> "cq",
> > "regex")
> > 
> > Why not just:
> > 
> > "....." % ('\n  '.join(trybots), ALL_BUILDERS, COMPILE_BUILDERS,
CQ_BUILDERS,
> > REGEX)
> > 
> > ?
> 
> This is how I did it first but then I worried about people adding more aliases
> and not updating documentation. This way if an alias is added and not
documented
> here then it will fail.
> Though I dont have a strong preference either way.

That makes sense. SGTM

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode210
tools/submit_try:210: using_bots = filter(lambda trybot: '_Compile_' in trybot,
trybots)
On 2013/04/08 21:11:38, rmistry wrote:
> On 2013/04/08 21:02:21, borenet wrote:
> > Is this faster than a list comprehension?
> 
> List comprehension is marginally faster but the performance difference is
> negligible in this (and majority of other) cases. People who prefer one of the
> two are divided in different camps in python, it all comes down to personal
> preference.

I guess I find the list comprehension more readable here, but I'll leave it up
to you.

https://codereview.chromium.org/13493012/diff/9001/tools/submit_try
File tools/submit_try (right):

https://codereview.chromium.org/13493012/diff/9001/tools/submit_try#newcode120
tools/submit_try:120: connection.request('GET', '/json/%s' % json_filename)
Nit: Still ends in a space

[rmistry, 2013-04-09 11:33:39]

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try
File tools/submit_try (right):

https://codereview.chromium.org/13493012/diff/4001/tools/submit_try#newcode210
tools/submit_try:210: using_bots = filter(lambda trybot: '_Compile_' in trybot,
trybots)
On 2013/04/08 21:15:50, borenet wrote:
> On 2013/04/08 21:11:38, rmistry wrote:
> > On 2013/04/08 21:02:21, borenet wrote:
> > > Is this faster than a list comprehension?
> > 
> > List comprehension is marginally faster but the performance difference is
> > negligible in this (and majority of other) cases. People who prefer one of
the
> > two are divided in different camps in python, it all comes down to personal
> > preference.
> 
> I guess I find the list comprehension more readable here, but I'll leave it up
> to you.

Changed to list comprehension. I did some more research yesterday and seems that
Python's BDFL wanted to remove filter but did not because of user feedback,
maybe that makes list comprehension more pythonic.

https://codereview.chromium.org/13493012/diff/9001/tools/submit_try
File tools/submit_try (right):

https://codereview.chromium.org/13493012/diff/9001/tools/submit_try#newcode120
tools/submit_try:120: connection.request('GET', '/json/%s' % json_filename)
On 2013/04/08 21:15:51, borenet wrote:
> Nit: Still ends in a space

Done.

[rmistry, 2013-04-09 11:46:51]

Committed patchset #5 manually as r8569 (presubmit successful).