Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7240)

Unified Diff: chrome/test/data/webrtc/webrtc-simulcast.html

Issue 1349273003: Update tests for chrome, as MediaStream label, ended attributes and stop() method will be removed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webrtc/webrtc-simulcast.html
diff --git a/chrome/test/data/webrtc/webrtc-simulcast.html b/chrome/test/data/webrtc/webrtc-simulcast.html
index de7c67a0b7b20561161d5f58d8eff00262ef3407..a5c49e7c7727e5b25d549b149e488f0ec25212b6 100644
--- a/chrome/test/data/webrtc/webrtc-simulcast.html
+++ b/chrome/test/data/webrtc/webrtc-simulcast.html
@@ -166,7 +166,7 @@ function didntGetStream(err) {
function openCamera(width, height) {
if (localStream) {
pcClient.removeStream(localStream);
- localStream.getVideoTracks().stop();
+ localStream.getVideoTracks()[0].stop();
localStream = null;
}
navigator.webkitGetUserMedia({
@@ -203,15 +203,8 @@ function onServerAnswer(desc) {
}
function onServerGotStream(e) {
- trace('Received remote stream: ' + e.stream.label +
- '; looking up corresponding video tag.');
-
- var remoteVideo = $(e.stream.label);
- if (!remoteVideo) {
- // All streams we receive must have a corresponding video tag defined in the
- // html, otherwise we can't detect video in it.
- throw 'Received video with unexpected id ' + e.stream.label;
- }
+ trace('Received remote stream, looking up corresponding video tag.');
+ var remoteVideo = e.stream;
philipj_slow 2015/09/22 09:08:09 I don't get this change, I think remoteVideo is no
shiva.jm 2015/09/23 03:29:51 Yes, right we need to use just e.stream.id instead
remoteVideo.src = webkitURL.createObjectURL(e.stream);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698