Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1349273003: Update tests for chrome, as MediaStream label, ended attributes and stop() method will be removed (Closed)

Created:
5 years, 3 months ago by shiva.jm
Modified:
5 years, 3 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update tests for chrome, as MediaStream label, ended attributes and stop() method will be removed Also CL: https://codereview.chromium.org/1312213006/ depends on these CL to commit first. Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/LcZGlM9OBqs Intent to Remove, which became an Intent to Deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/s0UsMk8i2YM/WpepA4w3mPEJ BUG=338500 Committed: https://crrev.com/7c38bcf2b60d6fa1276a81bb51f0f843ab77ca9b Cr-Commit-Position: refs/heads/master@{#350351}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/test/data/webrtc/webrtc-simulcast.html View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
shiva.jm
pls have a look. Patch https://codereview.chromium.org/1312213006/ depends on these patch, but do not have permission ...
5 years, 3 months ago (2015-09-22 05:59:57 UTC) #2
philipj_slow
Looks like the bots are pretty unhappy with this change, can you investigate? https://codereview.chromium.org/1349273003/diff/20001/chrome/test/data/webrtc/webrtc-simulcast.html File ...
5 years, 3 months ago (2015-09-22 09:08:10 UTC) #3
shiva.jm
updated the tests, pls have a look. https://codereview.chromium.org/1349273003/diff/20001/chrome/test/data/webrtc/webrtc-simulcast.html File chrome/test/data/webrtc/webrtc-simulcast.html (right): https://codereview.chromium.org/1349273003/diff/20001/chrome/test/data/webrtc/webrtc-simulcast.html#newcode207 chrome/test/data/webrtc/webrtc-simulcast.html:207: var remoteVideo ...
5 years, 3 months ago (2015-09-23 03:29:52 UTC) #4
shiva.jm
Test is passed now in few bots, but need help in building patch: https://codereview.chromium.org/1312213006/, using ...
5 years, 3 months ago (2015-09-23 06:54:00 UTC) #5
philipj_slow
If the bots are happy with this change, why do you need to build with ...
5 years, 3 months ago (2015-09-23 09:04:09 UTC) #6
tommi (sloooow) - chröme
lgtm
5 years, 3 months ago (2015-09-23 09:47:36 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349273003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349273003/60001
5 years, 3 months ago (2015-09-23 10:05:10 UTC) #9
shiva.jm
On 2015/09/23 09:04:09, philipj wrote: > If the bots are happy with this change, why ...
5 years, 3 months ago (2015-09-23 10:33:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349273003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349273003/60001
5 years, 3 months ago (2015-09-23 11:51:13 UTC) #13
philipj_slow
The Chromium-Blink merge is now underway, so if this doesn't land, then you can do ...
5 years, 3 months ago (2015-09-23 11:52:20 UTC) #14
shiva.jm
On 2015/09/23 11:52:20, philipj wrote: > The Chromium-Blink merge is now underway, so if this ...
5 years, 3 months ago (2015-09-23 11:53:36 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-23 18:31:59 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 18:36:11 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7c38bcf2b60d6fa1276a81bb51f0f843ab77ca9b
Cr-Commit-Position: refs/heads/master@{#350351}

Powered by Google App Engine
This is Rietveld 408576698