Mandoline: Enable more GL commands which are used by WebGL.

Mandoline: Enable more GL commands which are used by WebGL & GMap.

TEST=mandoline http://map.google.com
BUG=525159
Committed: https://crrev.com/de716269e4d05ab2c5bd695f5b79f129fec1b314
Cr-Commit-Position: refs/heads/master@{#349867}

[Peng, 2015-09-17 16:32:32]

penghuang@chromium.org changed reviewers:
+ piman@chromium.org, sky@chromium.org

[Peng, 2015-09-17 16:32:33]

Hi Antoine & Scott, Could you please take a look? Thanks.

https://codereview.chromium.org/1349233002/diff/1/gpu/command_buffer/build_gl...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/1349233002/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:11022: True)
I am wondering why not put all gl extension APIs in one file.

[sky, 2015-09-17 16:53:29]

I'm rubber stamping this: LGTM
In fact Antoine should really be an owner of most of this code.

[piman, 2015-09-17 23:51:38]

https://codereview.chromium.org/1349233002/diff/1/gpu/command_buffer/build_gl...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/1349233002/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:11022: True)
I would prefer if you tagged each function that you need with the extension it
comes from  (see gpu/GLES2/extensions/CHROMIUM). "'extension': True" is
deprecated....

As to whether or not to put all extensions into a single file, I don't have an
opinion.

[Peng, 2015-09-18 15:17:16]

https://codereview.chromium.org/1349233002/diff/1/gpu/command_buffer/build_gl...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/1349233002/diff/1/gpu/command_buffer/build_gl...
gpu/command_buffer/build_gles2_cmd_buffer.py:11022: True)
On 2015/09/17 23:51:38, piman (slow to review) wrote:
> I would prefer if you tagged each function that you need with the extension it
> comes from  (see gpu/GLES2/extensions/CHROMIUM). "'extension': True" is
> deprecated....

I tagged most functions, except several functions which I can not find in
extensions/CHROMIUM.

> 
> As to whether or not to put all extensions into a single file, I don't have an
> opinion.

I think putting all extensions into a single file could make it easier to
maintain. I merged them into one file.

Done

[piman, 2015-09-18 21:11:12]

LGTM+nit

https://codereview.chromium.org/1349233002/diff/20001/gpu/command_buffer/buil...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/1349233002/diff/20001/gpu/command_buffer/buil...
gpu/command_buffer/build_gles2_cmd_buffer.py:10883: """Provides the GL
implementation for mojo for a particular extension"""
nit: Fix comment

[Peng, 2015-09-19 14:13:31]

https://codereview.chromium.org/1349233002/diff/20001/gpu/command_buffer/buil...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/1349233002/diff/20001/gpu/command_buffer/buil...
gpu/command_buffer/build_gles2_cmd_buffer.py:10883: """Provides the GL
implementation for mojo for a particular extension"""
On 2015/09/18 21:11:12, piman (slow to review) wrote:
> nit: Fix comment

Done.

[Peng, 2015-09-19 14:13:40]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2015-09-19 14:13:40]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1349233002/#ps40001
(title: "Address review issue")

[commit-bot: I haz the power, 2015-09-19 14:13:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1349233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1349233002/40001

[commit-bot: I haz the power, 2015-09-19 14:47:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-19 14:47:19]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Peng, 2015-09-19 14:48:53]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2015-09-19 14:48:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1349233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1349233002/40001

[commit-bot: I haz the power, 2015-09-19 15:15:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-19 15:16:35]

Patchset 3 (id:??) landed as
https://crrev.com/de716269e4d05ab2c5bd695f5b79f129fec1b314
Cr-Commit-Position: refs/heads/master@{#349867}