Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 134923004: Revert 244286 "Password manager: Gnome support for Public Suffix..." (Closed)

Created:
6 years, 11 months ago by DaleCurtis
Modified:
6 years, 11 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 244286 "Password manager: Gnome support for Public Suffix..." > Password manager: Gnome support for Public Suffix List matching > > This CL: > > * Enables Public Suffix List (PSL) general utilities on Linux. > * Enables PSL flag for Linux. > * Adds Gnome Keyring support for searching and filtering multiple origins, including UMA metrics and a unit test. > > BUG=324291 > > Review URL: https://codereview.chromium.org/123223003 TBR=vabr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -128 lines) Patch
M trunk/src/chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/password_manager/native_backend_gnome_x.cc View 12 chunks +3 lines, -46 lines 0 comments Download
M trunk/src/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc View 6 chunks +2 lines, -80 lines 0 comments Download
M trunk/src/chrome/browser/password_manager/psl_matching_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
DaleCurtis
6 years, 11 months ago (2014-01-11 01:19:54 UTC) #1
DaleCurtis
Committed patchset #1 manually as r244292.
6 years, 11 months ago (2014-01-11 01:20:10 UTC) #2
DaleCurtis
Broke lsan portion of asan bot: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/21636
6 years, 11 months ago (2014-01-11 01:20:32 UTC) #3
Lei Zhang
Direct leak of 576 byte(s) in 1 object(s) allocated from: #0 0x4ba519 in operator new(unsigned ...
6 years, 11 months ago (2014-01-11 01:41:21 UTC) #4
vabr (Chromium)
6 years, 11 months ago (2014-01-13 08:28:48 UTC) #5
Message was sent while issue was closed.
LGTM.

Thanks for reverting and the helpful trace!

Vaclav

Powered by Google App Engine
This is Rietveld 408576698