Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: trunk/src/build/android/gyp/lint.py

Issue 134923003: Revert 244256 "[Android] Enable lint warnings by default." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/build/android/buildbot/bb_run_bot.py ('k') | trunk/src/build/common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/build/android/gyp/lint.py
===================================================================
--- trunk/src/build/android/gyp/lint.py (revision 244265)
+++ trunk/src/build/android/gyp/lint.py (working copy)
@@ -55,15 +55,17 @@
print >> sys.stderr
for issue in issues:
issue_id = issue.attributes['id'].value
+ severity = issue.attributes['severity'].value
message = issue.attributes['message'].value
location_elem = issue.getElementsByTagName('location')[0]
path = location_elem.attributes['file'].value
line = location_elem.getAttribute('line')
if line:
- error = '%s:%s %s: %s [warning]' % (path, line, message, issue_id)
+ error = '%s:%s %s: %s [%s]' % (path, line, severity, message,
+ issue_id)
else:
# Issues in class files don't have a line number.
- error = '%s %s: %s [warning]' % (path, message, issue_id)
+ error = '%s %s: %s [%s]' % (path, severity, message, issue_id)
print >> sys.stderr, error
for attr in ['errorLine1', 'errorLine2']:
error_line = issue.getAttribute(attr)
« no previous file with comments | « trunk/src/build/android/buildbot/bb_run_bot.py ('k') | trunk/src/build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698