Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1349183002: [tracing] Rename WebMemoryDumpLevelOfDetail enums to match chromium (Closed)

Created:
5 years, 3 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 3 months ago
CC:
Mads Ager (chromium), blink-reviews, dglazkov+blink, kouhei+heap_chromium.org, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[tracing] Rename WebMemoryDumpLevelOfDetail enums to match chromium Non-functional refactor to match names in the chromium repo as per crrev.com/1337943003 Just changes the names of WebMemoryDumpLevelOfDetail constants. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/platform/PartitionAllocMemoryDumpProvider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/BlinkGCMemoryDumpProvider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebMemoryDumpProvider.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Primiano Tucci (use gerrit)
5 years, 3 months ago (2015-09-17 13:23:31 UTC) #2
haraken
LGTM % public/.
5 years, 3 months ago (2015-09-17 13:27:35 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-17 13:29:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349183002/1
5 years, 3 months ago (2015-09-17 14:27:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/99178)
5 years, 3 months ago (2015-09-17 14:27:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349183002/1
5 years, 3 months ago (2015-09-18 08:29:23 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 09:51:28 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202515

Powered by Google App Engine
This is Rietveld 408576698