Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

Issue 1349163008: Setting chrome as the default browser is now fixed on Windows 10 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation again Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/external_protocol/external_protocol_handler_unittest.cc
diff --git a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
index 53cfd6633c2a8082b30a4f915820805abb46137c..f7d3511fe47395489a47d2824ebbe24d91c73d18 100644
--- a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
+++ b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
@@ -23,11 +23,20 @@ class FakeExternalProtocolHandlerWorker
private:
~FakeExternalProtocolHandlerWorker() override {}
- ShellIntegration::DefaultWebClientState CheckIsDefault() override {
- return os_state_;
+ void CheckIsDefault() override {
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ base::Bind(&FakeExternalProtocolHandlerWorker::OnCheckIsDefaultComplete,
+ this, os_state_));
}
- bool SetAsDefault(bool interactive_permitted) override { return true; }
+ void SetAsDefault(bool interactive_permitted) override {
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ base::Bind(
+ &FakeExternalProtocolHandlerWorker::OnSetAsDefaultAttemptComplete,
+ this, AttemptResult::SUCCESS));
+ }
ShellIntegration::DefaultWebClientState os_state_;
};

Powered by Google App Engine
This is Rietveld 408576698