chrome/browser/external_protocol/external_protocol_handler_unittest.cc - Issue 1349163008: Setting chrome as the default browser is now fixed on Windows 10

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

Issue 1349163008: Setting chrome as the default browser is now fixed on Windows 10 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Now using OpenWith.exe to open the http url Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc ('k') | chrome/browser/shell_integration.h » ('j') | chrome/browser/shell_integration.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/external_protocol/external_protocol_handler_unittest.cc

diff --git a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

index 53cfd6633c2a8082b30a4f915820805abb46137c..6d3ccc413511ac6e2dee2296d27d577c2fc5003d 100644

--- a/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

+++ b/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

@@ -27,7 +27,12 @@ class FakeExternalProtocolHandlerWorker

return os_state_;

}

- bool SetAsDefault(bool interactive_permitted) override { return true; }

+ void SetAsDefault(bool interactive_permitted) override {

+ BrowserThread::PostTask(

+ BrowserThread::UI, FROM_HERE,

+ base::Bind(&FakeExternalProtocolHandlerWorker::CompleteSetAsDefault,

+ this, true));

+ }

ShellIntegration::DefaultWebClientState os_state_;

};