Setting chrome as the default browser is now fixed on Windows 10

chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

Index: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
diff --git a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
index f246291f46b1c3ce59aa09842efc656f7e161598..371b80313eb050ee1efa9682691328206bdd4bb3 100644
--- a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
+++ b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
@@ -226,15 +226,24 @@ class FakeProtocolClientWorker
  private:
   ~FakeProtocolClientWorker() override {}
 
-  ShellIntegration::DefaultWebClientState CheckIsDefault() override {
+  void CheckIsDefault() override {
+    ShellIntegration::DefaultWebClientState state =

[Peter Kasting, 2015/09/25 20:52:25]

Nit: Are the class name qualifiers really needed here?

[Patrick Monette, 2015/09/28 23:46:36]

Yes

+        ShellIntegration::IS_DEFAULT;
     if (force_failure_) {

[Peter Kasting, 2015/09/25 20:52:25]

Nit: {} unnecessary

[Patrick Monette, 2015/09/28 23:46:36]

Removed.

-      return ShellIntegration::NOT_DEFAULT;
-    } else {
-      return ShellIntegration::IS_DEFAULT;
+      state = ShellIntegration::NOT_DEFAULT;
     }
+    BrowserThread::PostTask(
+        BrowserThread::UI, FROM_HERE,
+        base::Bind(&FakeProtocolClientWorker::CompleteCheckIsDefault, this,
+                   state));
   }
 
-  bool SetAsDefault(bool interactive_permitted) override { return true; }
+  void SetAsDefault(bool interactive_permitted) override {
+    BrowserThread::PostTask(
+        BrowserThread::UI, FROM_HERE,
+        base::Bind(&FakeProtocolClientWorker::CompleteSetAsDefault, this,
+                   true));
+  }
 
  private:
   bool force_failure_;