Setting chrome as the default browser is now fixed on Windows 10

chrome/browser/ui/startup/startup_browser_creator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_STARTUP_STARTUP_BROWSER_CREATOR_H_
 #define CHROME_BROWSER_UI_STARTUP_STARTUP_BROWSER_CREATOR_H_
 
+#include <map>

[grt (UTC plus 2), 2015/09/24 18:24:12]

unused

[Patrick Monette, 2015/09/25 20:06:25]

Removed.

 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
 #include "base/gtest_prod_util.h"
 #include "chrome/browser/prefs/session_startup_pref.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/startup/startup_tab.h"
 #include "chrome/browser/ui/startup/startup_types.h"
@@ skipping 78 matching lines @@
 
   bool show_main_browser_window() const {
     return show_main_browser_window_;
   }
 
   // For faking that no profiles have been launched yet.
   static void ClearLaunchedProfilesForTesting();
 
   static void RegisterLocalStatePrefs(PrefRegistrySimple* registry);
 
+#if defined(OS_WIN)
+  // Setting Chrome as the default browser in Windows 10+ requires a specific
+  // url to be opened through openwith.exe. We intercept this url in
+  // ProcessCmdLineImpl when the interceptor is set. See DefaultBrowserWorker in
+  // shell_integration.h for more details.
+  static void SetAsyncSetAsDefaultFilter(base::Closure callback);

[Peter Kasting, 2015/09/23 23:01:39]

I find the consistent use of the phrase "AsyncSetAsDefault" everywhere
confusing, since I can barely parse it, it leads to multiple verbs in a row
("set async set"), and it doesn't say "default what".  Something like this:

SetDefaultBrowserCallback();
GetDefaultBrowserURL();

...might be clearer.

[grt (UTC plus 2), 2015/09/24 18:24:12]

nit: pass callbacks by constref

[Patrick Monette, 2015/09/25 20:06:25]

Done.

[Patrick Monette, 2015/09/25 20:06:25]

Done.

+
+  // Clears the filter when it isn't needed anymore.
+  static void ClearAsyncSetAsDefaultFilter();
+
+  // Returns the url used to set Chrome as the default browser asynchronously.
+  static const wchar_t* GetAsyncSetAsDefaultUrl();
+#endif  // defined(OS_WIN)
+
+  // All the filters functions should be called on the UI thread.

[Peter Kasting, 2015/09/23 23:01:39]

Looks like all this should have been removed?

[Patrick Monette, 2015/09/25 20:06:25]

Yes. Removed.

+  /*
+  // Adds a new filter that will execute the |callback| when the |url| is opened
+  // through the command line.
+  static void AddUrlFilter(const GURL& url,
+                           const base::Callback<void(void)>& callback);
+
+  // Removes the filter associated the the |url|.
+  static void RemoveUrlFilter(const GURL& url);
+
+  // Returns true if at least one url filter exists.
+  static bool HasUrlFilters();
+
+  // Executes the callback associated to the |url| filter. Returns false if the
+  // |url| isn't associated to any filters.
+  static bool ExecuteFilterCallback(const GURL& url);
+
+  // Returns true if a filter is associated to the |url|.
+  static bool UrlFilterExists(const GURL& url);*/
+
  private:
   friend class CloudPrintProxyPolicyTest;
   friend class CloudPrintProxyPolicyStartupTest;
   friend class StartupBrowserCreatorImpl;
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest,
                            ReadingWasRestartedAfterNormalStart);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest,
                            ReadingWasRestartedAfterRestart);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest, UpdateWithTwoProfiles);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest, LastUsedProfileActivated);
@@ skipping 58 matching lines @@
 // Returns true if |profile| has exited uncleanly and has not been launched
 // after the unclean exit.
 bool HasPendingUncleanExit(Profile* profile);
 
 // Returns the path that contains the profile that should be loaded on process
 // startup.
 base::FilePath GetStartupProfilePath(const base::FilePath& user_data_dir,
                                      const base::CommandLine& command_line);
 
 #endif  // CHROME_BROWSER_UI_STARTUP_STARTUP_BROWSER_CREATOR_H_