Setting chrome as the default browser is now fixed on Windows 10

chrome/browser/ui/startup/startup_browser_creator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_STARTUP_STARTUP_BROWSER_CREATOR_H_
 #define CHROME_BROWSER_UI_STARTUP_STARTUP_BROWSER_CREATOR_H_
 
+#include <map>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
 #include "base/gtest_prod_util.h"
 #include "chrome/browser/prefs/session_startup_pref.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/startup/startup_tab.h"
 #include "chrome/browser/ui/startup/startup_types.h"
 #include "url/gurl.h"
 
 class Browser;
 class GURL;
 class PrefRegistrySimple;
 class PrefService;
 
 namespace base {
 class CommandLine;
 }
 
 // class containing helpers for BrowserMain to spin up a new instance and
 // initialize the profile.
 class StartupBrowserCreator {
  public:
   typedef std::vector<Profile*> Profiles;
+  typedef std::map<GURL, base::Callback<void(void)>> UrlFilters;

[grt (UTC plus 2), 2015/09/22 18:21:48]

base::Callback<void(void)> -> base::Closure

 
   StartupBrowserCreator();
   ~StartupBrowserCreator();
 
   // Adds a url to be opened during first run. This overrides the standard
   // tabs shown at first run.
   void AddFirstRunTab(const GURL& url);
 
   // This function is equivalent to ProcessCommandLine but should only be
   // called during actual process startup.
@@ skipping 52 matching lines @@
 
   bool show_main_browser_window() const {
     return show_main_browser_window_;
   }
 
   // For faking that no profiles have been launched yet.
   static void ClearLaunchedProfilesForTesting();
 
   static void RegisterLocalStatePrefs(PrefRegistrySimple* registry);
 
+  // All the filters functions should be called on the UI thread.

[grt (UTC plus 2), 2015/09/22 18:21:48]

comment suggestion:
  // Adds a filter that will execute |closure| on the UI thread when |url| is
  // opened via the command-line.

+  // Adds a new filter that will execute the |callback| when the |url| is opened
+  // through the command line.
+  static void AddUrlFilter(const GURL& url,
+                           const base::Callback<void(void)>& callback);

[grt (UTC plus 2), 2015/09/22 18:21:48]

base::Callback<void(void)> -> base::Closure

+
+  // Removes the filter associated the the |url|.
+  static void RemoveUrlFilter(const GURL& url);
+
+  // Returns true if at least one url filter exists.

[grt (UTC plus 2), 2015/09/22 18:21:48]

this doesn't look like it needs to be part of the public api, does it?

+  static bool HasUrlFilters();
+
+  // Executes the callback associated to the |url| filter. Returns false if the
+  // |url| isn't associated to any filters.
+  static bool ExecuteFilterCallback(const GURL& url);

[grt (UTC plus 2), 2015/09/22 18:21:48]

does this need to be public?

+
+  // Returns true if a filter is associated to the |url|.
+  static bool UrlFilterExists(const GURL& url);
+
  private:
   friend class CloudPrintProxyPolicyTest;
   friend class CloudPrintProxyPolicyStartupTest;
   friend class StartupBrowserCreatorImpl;
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest,
                            ReadingWasRestartedAfterNormalStart);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest,
                            ReadingWasRestartedAfterRestart);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest, UpdateWithTwoProfiles);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest, LastUsedProfileActivated);
@@ skipping 26 matching lines @@
   static void ProcessCommandLineOnProfileCreated(
       const base::CommandLine& command_line,
       const base::FilePath& cur_dir,
       Profile* profile,
       Profile::CreateStatus status);
 
   // Returns true once a profile was activated. Used by the
   // StartupBrowserCreatorTest.LastUsedProfileActivated test.
   static bool ActivatedProfile();
 
+  // Returns the map of all the url filters. This will creatE the filter if it

[grt (UTC plus 2), 2015/09/22 18:21:47]

creatE -> create

+  // doesn't exist.
+  static UrlFilters* GetUrlFilters();
+
   // Additional tabs to open during first run.
   std::vector<GURL> first_run_tabs_;
 
   // True if the set-as-default dialog has been explicitly suppressed.
   // This information is used to allow the default browser prompt to show on
   // first-run when the dialog has been suppressed.
   bool is_default_browser_dialog_suppressed_;
 
   // Whether the browser window should be shown immediately after it has been
   // created. Default is true.
@@ skipping 12 matching lines @@
 // Returns true if |profile| has exited uncleanly and has not been launched
 // after the unclean exit.
 bool HasPendingUncleanExit(Profile* profile);
 
 // Returns the path that contains the profile that should be loaded on process
 // startup.
 base::FilePath GetStartupProfilePath(const base::FilePath& user_data_dir,
                                      const base::CommandLine& command_line);
 
 #endif  // CHROME_BROWSER_UI_STARTUP_STARTUP_BROWSER_CREATOR_H_