Setting chrome as the default browser is now fixed on Windows 10

chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <string>
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/prefs/pref_service.h"
@@ skipping 82 matching lines @@
 }
 
 bool IsWindows10OrNewer() {
 #if defined(OS_WIN)
   return base::win::GetVersion() >= base::win::VERSION_WIN10;
 #else
   return false;
 #endif
 }
 
+// This function is used to verify a callback was successfully invoked.
+void SetTrue(bool* value) {
+  ASSERT_TRUE(value);
+  *value = true;
+}
+
+bool TabStripContainsUrl(TabStripModel* tab_strip, GURL url) {
+  for (int i = 0; i < tab_strip->count(); i++) {

[Peter Kasting, 2015/09/25 20:52:27]

Tiny nit: There's no formal rule requiring this but I tend to prefer
preincrement whenever you don't actually need a postincrement.

[Patrick Monette, 2015/09/28 23:46:38]

Done.

+    if (tab_strip->GetWebContentsAt(i)->GetURL() == url)
+      return true;
+  }
+  return false;
+}
+
+void ProcessCommandLineAlreadyRunningDefaultProfile(base::CommandLine cmdline) {

[grt (UTC plus 2), 2015/09/28 14:31:05]

nit: pass by constref

[Patrick Monette, 2015/09/28 23:46:38]

Done.

+  StartupBrowserCreator browser_creator;
+
+  base::FilePath current_dir;
+  ASSERT_TRUE(base::GetCurrentDirectory(&current_dir));
+  base::FilePath user_data_dir =
+      g_browser_process->profile_manager()->user_data_dir();
+  base::FilePath startup_profile_dir =
+      g_browser_process->profile_manager()->GetLastUsedProfileDir(
+          user_data_dir);
+
+  browser_creator.ProcessCommandLineAlreadyRunning(cmdline, current_dir,
+                                                   startup_profile_dir);
+}
+
 }  // namespace
 
 class StartupBrowserCreatorTest : public ExtensionBrowserTest {
  protected:
   StartupBrowserCreatorTest() {}
 
   bool SetUpUserDataDirectory() override {
     return ExtensionBrowserTest::SetUpUserDataDirectory();
   }
 
@@ skipping 1040 matching lines @@
             tab_strip->GetWebContentsAt(0)->GetURL());
   EnsureRestoreUIWasShown(tab_strip->GetWebContentsAt(0));
 
 #if !defined(OS_MACOSX) && !defined(GOOGLE_CHROME_BUILD)
   // Each profile should have one session restore bubble shown, so we should
   // observe count 3 in bucket 0 (which represents bubble shown).
   histogram_tester.ExpectBucketCount("SessionCrashed.Bubble", 0, 3);
 #endif  // !defined(OS_MACOSX) && !defined(GOOGLE_CHROME_BUILD)
 }
 
+#if defined(OS_WIN)
+IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, DefaultBrowserCallback) {
+  bool callback_called = false;
+
+  // Set the default browser callback.
+  StartupBrowserCreator::SetDefaultBrowserCallback(
+      base::Bind(&SetTrue, &callback_called));
+
+  // Set the command line to open the default browser url.
+  base::CommandLine cmdline(base::CommandLine::NO_PROGRAM);
+  cmdline.AppendArgNative(StartupBrowserCreator::GetDefaultBrowserUrl());
+
+  // Open url.
+  ProcessCommandLineAlreadyRunningDefaultProfile(cmdline);
+
+  // The url should have been intercepted and the callback invoked.
+  GURL default_browser_url =
+      GURL(StartupBrowserCreator::GetDefaultBrowserUrl());
+  EXPECT_FALSE(
+      TabStripContainsUrl(browser()->tab_strip_model(), default_browser_url));
+  EXPECT_TRUE(callback_called);
+
+  // Clear default browser callback.
+  callback_called = false;
+  StartupBrowserCreator::ClearDefaultBrowserCallback();
+
+  // Open url.
+  ProcessCommandLineAlreadyRunningDefaultProfile(cmdline);
+
+  // The url should not have been intercepted and the callback not invoked.
+  EXPECT_TRUE(
+      TabStripContainsUrl(browser()->tab_strip_model(), default_browser_url));
+  EXPECT_FALSE(callback_called);
+}
+#endif  // defined(OS_WIN)
+
 class SupervisedUserBrowserCreatorTest : public InProcessBrowserTest {
  protected:
   void SetUpCommandLine(base::CommandLine* command_line) override {
     InProcessBrowserTest::SetUpCommandLine(command_line);
     command_line->AppendSwitchASCII(switches::kSupervisedUserId, "asdf");
   }
 };
 
 IN_PROC_BROWSER_TEST_F(SupervisedUserBrowserCreatorTest,
                        StartupSupervisedUserProfile) {
@@ skipping 456 matching lines @@
   ASSERT_EQ(1, tab_strip->count());
   EXPECT_EQ("title1.html",
             tab_strip->GetWebContentsAt(0)->GetURL().ExtractFileName());
 }
 #endif  // defined(ENABLE_CONFIGURATION_POLICY)
 
 #endif  // !defined(OS_LINUX) || !defined(GOOGLE_CHROME_BUILD) ||
         // defined(ENABLE_CONFIGURATION_POLICY)
 
 #endif  // !defined(OS_CHROMEOS)