Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1349073002: Fix browser_tests on 32-bit linux (Closed)

Created:
5 years, 3 months ago by guoweis_left_chromium
Modified:
5 years, 3 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix browser_tests on 32-bit linux. Missing dtor in WebRTCIceServerArray. The bug was introduced by https://codereview.chromium.org/1315413004/ but showed in the run of https://codereview.chromium.org/1321543002/. BUG=webrtc:4517 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M public/platform/WebRTCConfiguration.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
guoweis_left_chromium
On 2015/09/17 04:52:52, guoweis_chromium wrote: > mailto:guoweis@chromium.org changed reviewers: > + mailto:thakis@chromium.org, mailto:tommi@chromium.org PTAL.
5 years, 3 months ago (2015-09-17 04:53:29 UTC) #2
tommi (sloooow) - chröme
lgtm
5 years, 3 months ago (2015-09-17 05:46:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349073002/1
5 years, 3 months ago (2015-09-17 06:20:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/100868)
5 years, 3 months ago (2015-09-17 06:28:50 UTC) #7
guoweis_left_chromium
PTAL
5 years, 3 months ago (2015-09-17 16:13:55 UTC) #10
Nico
rs-lgtm
5 years, 3 months ago (2015-09-17 17:52:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1349073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1349073002/1
5 years, 3 months ago (2015-09-17 17:58:06 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 18:04:00 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202459

Powered by Google App Engine
This is Rietveld 408576698