third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui_component.h - Issue 134903003: libaddressinput string translations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui_component.h

Issue 134903003: libaddressinput string translations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui.h ('K') | « third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui.h ('k') | third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_validator.h » ('j') | third_party/libaddressinput/chromium/cpp/res/messages.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui_component.h

diff --git a/third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui_component.h b/third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui_component.h

index 5982a29f00398ae726607b46f32fcf18cf8b6ade..eca0a239e45f64f4d591620a1219324268a981ca 100644

--- a/third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui_component.h

+++ b/third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui_component.h

@@ -35,8 +35,8 @@ struct AddressUiComponent {

// The address field type for this UI component, for example LOCALITY.

AddressField field;

- // The name of the field, for example "City".

- std::string name;

+ // The id of the string for the name of the field, for example "City".

please use gerrit instead 2014/01/13 18:50:13 Let's keep the ID vs id capitalization consistent.

Evan Stade 2014/01/13 23:36:07 Done.

+ int name_id;

// The hint for how large the input field should be in a multiline address

// form.