Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_problem.h

Issue 134903003: libaddressinput string translations (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_problem.h
diff --git a/third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_problem.h b/third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_problem.h
index 841f8d19828e1cc2677ec772f756e0dd72e50354..da2117e3184072798d273f9bfb3c296fc512c275 100644
--- a/third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_problem.h
+++ b/third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_problem.h
@@ -59,7 +59,7 @@ struct AddressProblem {
MISMATCHING_VALUE
};
- AddressProblem(AddressField field, Type type, const std::string& description);
+ AddressProblem(AddressField field, Type type, int description_id);
~AddressProblem();
// The address field that has the problem.
@@ -68,8 +68,9 @@ struct AddressProblem {
// The type of problem.
Type type;
- // The human readable description of the problem.
- std::string description;
+ // The ID for the string that is the human readable description of the
please use gerrit instead 2014/01/13 18:50:13 Let's keep the ID vs id capitalization consistent.
Evan Stade 2014/01/13 23:36:07 Done.
+ // problem.
+ int description_id;
};
// Produces human-readable output in logging, for example in unit tests.

Powered by Google App Engine
This is Rietveld 408576698