libaddressinput string translations

chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc

Index: chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc b/chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc
index f642bbf46726a782f8bb9f184480f4381882fb22..cc3d5bd7dc1db414a28b1a5bb585658d7fcb6f83 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc
@@ -9,12 +9,13 @@
 #include "chrome/common/chrome_switches.h"
 #include "components/autofill/core/browser/field_types.h"
 #include "grit/component_strings.h"
-#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_field.h"
-#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_ui.h"
-#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_ui_component.h"
-#include "third_party/libaddressinput/src/cpp/include/libaddressinput/localization.h"
+#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_field.h"
+#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui.h"
+#include "third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui_component.h"
 #include "ui/base/l10n/l10n_util.h"
 
+#include "grit/libaddressinput_strings.h"

[Mark Mentovai, 2014/01/13 16:43:36]

Why not in-line with the #includes above?

[Evan Stade, 2014/01/13 23:36:07]

This include is not necessary at all, it was only here to support debugging code
(this is part of the aforementioned cleanup that was necessary before full
review).

+
 namespace autofill {
 namespace i18ninput {
 
@@ -66,11 +67,10 @@ bool Enabled() {
 void BuildAddressInputs(common::AddressType address_type,
                         const std::string& country_code,
                         DetailInputs* inputs) {
-  i18n::addressinput::Localization localization;
-  // TODO(dbeam): figure out how to include libaddressinput's translations into
-  // some .pak file so I can call |SetGetter(&l10n_util::GetStringUTF8)| here.
+  NOTIMPLEMENTED() << " SOME STRING CALLED IDS_LIBADDRESSINPUT_I18N_DEPENDENT_LOCALITY_LABEL is ID " << IDS_LIBADDRESSINPUT_I18N_DEPENDENT_LOCALITY_LABEL << " and string is " << l10n_util::GetStringUTF16(IDS_LIBADDRESSINPUT_I18N_DEPENDENT_LOCALITY_LABEL);

[please use gerrit instead, 2014/01/13 18:50:13]

Is this a debug log?

[Evan Stade, 2014/01/13 23:36:07]

yes. This is a concrete example of this CL not being ready for review.

+
   std::vector<AddressUiComponent> components(
-      i18n::addressinput::BuildComponents(country_code, localization));
+      i18n::addressinput::BuildComponents(country_code));
 
   const bool billing = address_type == common::ADDRESS_TYPE_BILLING;
 
@@ -83,7 +83,7 @@ void BuildAddressInputs(common::AddressType address_type,
 
     ServerFieldType server_type = GetServerType(component.field, billing);
     DetailInput::Length length = LengthFromHint(component.length_hint);
-    base::string16 placeholder = base::UTF8ToUTF16(component.name);
+    base::string16 placeholder = l10n_util::GetStringUTF16(component.name_id);
     DetailInput input = { length, server_type, placeholder };
     inputs->push_back(input);
 
@@ -91,7 +91,7 @@ void BuildAddressInputs(common::AddressType address_type,
       // TODO(dbeam): support more than 2 address lines. http://crbug.com/324889
       ServerFieldType server_type =
           billing ? ADDRESS_BILLING_LINE2 : ADDRESS_HOME_LINE2;
-      base::string16 placeholder = base::UTF8ToUTF16(component.name);
+      base::string16 placeholder = l10n_util::GetStringUTF16(component.name_id);
       DetailInput input = { length, server_type, placeholder };
       inputs->push_back(input);
     }