libaddressinput string translations

chrome/chrome_browser_ui.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'browser_ui',
       'type': 'static_library',
       'variables': { 'enable_wexit_time_destructors': 1, },
@@ skipping 3345 matching lines @@
           'sources!': [
             'browser/ui/autofill/autofill_dialog_common.cc',
             'browser/ui/autofill/autofill_dialog_common.h',
             'browser/ui/autofill/data_model_wrapper.cc',
             'browser/ui/autofill/data_model_wrapper.h',
           ],
         }],
         ['enable_autofill_dialog==1 and OS!="android"', {
           'dependencies': [
             '../third_party/libaddressinput/libaddressinput.gyp:libaddressinput',
+            '../third_party/libaddressinput/libaddressinput.gyp:libaddressinput_strings',

[please use gerrit instead, 2014/01/13 18:50:13]

The dependency on libaddressinput_strings should not be necessary, because the
libaddressinput target already depends on it.

[Evan Stade, 2014/01/13 23:36:07]

I don't think we're supposed to rely on transitive dependencies. This is here
because code in chrome/browser/ui/autofill/ directly relies on this target.

           ],
         }, { # enable_autofill_dialog!=1 or OS=="android"
           'sources!': [
             'browser/ui/autofill/autofill_dialog_controller_impl.cc',
             'browser/ui/autofill/autofill_dialog_controller_impl.h',
             'browser/ui/autofill/autofill_dialog_i18n_input.cc',
             'browser/ui/autofill/autofill_dialog_i18n_input.h',
             'browser/ui/autofill/autofill_dialog_view.h',
             'browser/ui/autofill/autofill_dialog_view.cc',
             'browser/ui/autofill/autofill_dialog_view_delegate.h',
@@ skipping 16 matching lines @@
             'browser/ui/webui/local_discovery/local_discovery_ui.cc',
             'browser/ui/webui/local_discovery/local_discovery_ui.h',
             'browser/ui/webui/local_discovery/local_discovery_ui_handler.cc',
             'browser/ui/webui/local_discovery/local_discovery_ui_handler.h',
           ],
         }],
       ],
     },
   ],
 }