OLD | NEW |
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 import os | 5 import os |
6 import re | 6 import re |
7 import sys | 7 import sys |
8 import subprocess | 8 import subprocess |
9 | 9 |
10 | 10 |
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
58 if name_parts[0] != 'ppapi': | 58 if name_parts[0] != 'ppapi': |
59 continue | 59 continue |
60 | 60 |
61 # Only examine public plugin facing directories. | 61 # Only examine public plugin facing directories. |
62 if name_parts[1] not in ['api', 'c', 'cpp', 'utility']: | 62 if name_parts[1] not in ['api', 'c', 'cpp', 'utility']: |
63 continue | 63 continue |
64 | 64 |
65 # Only examine public stable interfaces. | 65 # Only examine public stable interfaces. |
66 if name_parts[2] in ['dev', 'private', 'trusted']: | 66 if name_parts[2] in ['dev', 'private', 'trusted']: |
67 continue | 67 continue |
| 68 if name_parts[2] == 'extensions' and name_parts[3] == 'dev': |
| 69 continue |
68 | 70 |
69 filepath = os.path.join('..', filename) | 71 filepath = os.path.join('..', filename) |
70 if RE_TODO.search(open(filepath, 'rb').read()): | 72 if RE_TODO.search(open(filepath, 'rb').read()): |
71 todo.append(filename) | 73 todo.append(filename) |
72 | 74 |
73 if todo: | 75 if todo: |
74 return [output_api.PresubmitError( | 76 return [output_api.PresubmitError( |
75 'TODOs found in stable public PPAPI files:', | 77 'TODOs found in stable public PPAPI files:', |
76 long_text='\n'.join(todo))] | 78 long_text='\n'.join(todo))] |
77 return [] | 79 return [] |
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
233 | 235 |
234 return results | 236 return results |
235 | 237 |
236 | 238 |
237 def CheckChangeOnUpload(input_api, output_api): | 239 def CheckChangeOnUpload(input_api, output_api): |
238 return CheckChange(input_api, output_api) | 240 return CheckChange(input_api, output_api) |
239 | 241 |
240 | 242 |
241 def CheckChangeOnCommit(input_api, output_api): | 243 def CheckChangeOnCommit(input_api, output_api): |
242 return CheckChange(input_api, output_api) | 244 return CheckChange(input_api, output_api) |
OLD | NEW |