Add internal operation that converts a growable list to a fixed list.

runtime/lib/internal_patch.dart

Index: runtime/lib/internal_patch.dart
diff --git a/runtime/lib/internal_patch.dart b/runtime/lib/internal_patch.dart
index c4618bc60b69a7cac8d7ddacd25c37ea3840f96a..cbb804423e54f6883921cc3d4da13ea0d0d28ac3 100644
--- a/runtime/lib/internal_patch.dart
+++ b/runtime/lib/internal_patch.dart
@@ -1,3 +1,13 @@
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
+
+patch List makeListFixedLength(List growableList)

[Ivan Posva, 2014/02/11 04:14:26]

I am really wondering why you have to go through a special static class to patch
a top-level function with a native function. I was under the strong impression
that we had done that in other places before and that it should just work. If
not please let us know as this is something we should address.

+    => _StaticClass.makeListFixedLength(growableList);
+
+// Making the native method static, not top-level.
+// See http://dartbug.com/6997
+class _StaticClass {

[floitsch, 2014/02/10 13:25:49]

You should probably also rename this class, so that the API name is not so
strange.

[Lasse Reichstein Nielsen, 2014/02/11 07:08:47]

class removed.

+  static List makeListFixedLength(List growableList)

[floitsch, 2014/02/10 13:25:49]

Add comment, explaining what this does.
In particular it must explain that the returned list can be either the input or
a new list (in which case the old list is destroyed and must not be reused).

[Lasse Reichstein Nielsen, 2014/02/11 07:08:47]

Comment added on external declaration.

+    native "StaticClass_toFixedLength";

[floitsch, 2014/02/10 13:25:49]

indentation ?

[floitsch, 2014/02/10 13:25:49]

StaticClass_toFixedLength

[Lasse Reichstein Nielsen, 2014/02/11 07:08:47]

All gone.

+}