runtime/lib/internal_patch.dart - Issue 134893003: Add internal operation that converts a growable list to a fixed list.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/internal_patch.dart

Issue 134893003: Add internal operation that converts a growable list to a fixed list. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rename native to STaticClass_toFixedLength Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 patch List makeListFixedLength(List growableList)
	Ivan Posva 2014/02/11 04:14:26 I am really wondering why you have to go through a I am really wondering why you have to go through a special static class to patch a top-level function with a native function. I was under the strong impression that we had done that in other places before and that it should just work. If not please let us know as this is something we should address.
	6 => _StaticClass.makeListFixedLength(growableList);

	7

	8 // Making the native method static, not top-level.

	9 // See http://dartbug.com/6997

	10 class _StaticClass {
	floitsch 2014/02/10 13:25:49 You should probably also rename this class, so tha You should probably also rename this class, so that the API name is not so strange. Lasse Reichstein Nielsen 2014/02/11 07:08:47 class removed. class removed.
	11 static List makeListFixedLength(List growableList)
	floitsch 2014/02/10 13:25:49 Add comment, explaining what this does. In particu Add comment, explaining what this does. In particular it must explain that the returned list can be either the input or a new list (in which case the old list is destroyed and must not be reused). Lasse Reichstein Nielsen 2014/02/11 07:08:47 Comment added on external declaration. Comment added on external declaration.
	12 native "StaticClass_toFixedLength";
	floitsch 2014/02/10 13:25:49 indentation ? indentation ? floitsch 2014/02/10 13:25:49 StaticClass_toFixedLength StaticClass_toFixedLength Lasse Reichstein Nielsen 2014/02/11 07:08:47 All gone. All gone.
	13 }

OLD	NEW

« runtime/lib/growable_array.cc ('K') | « runtime/lib/growable_array.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | runtime/vm/bootstrap_natives.h » ('J')