runtime/lib/internal_patch.dart - Issue 134893003: Add internal operation that converts a growable list to a fixed list.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/internal_patch.dart

Issue 134893003: Add internal operation that converts a growable list to a fixed list. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 patch List makeListFixedLength(List growableList)

	6 => _StaticClass.makeListFixedLength(growableList);

	7

	8 // Making the native class static, not top-level.

	9 class _StaticClass {
	Ivan Posva 2014/02/06 16:57:00 Why is it necessary to jump through multiple hoops Why is it necessary to jump through multiple hoops here? Lasse Reichstein Nielsen 2014/02/07 12:55:25 I had problems making the top-level patch function I had problems making the top-level patch function be a native function. Making it forward to a class static method worked. If there is a simpler way, I'd love to make it simpler! floitsch 2014/02/07 15:13:13 I guess it's issue 6997. Show quoted text On 2014/02/07 12:55:25, Lasse Reichstein Nielsen wrote: > I had problems making the top-level patch function be a native function. > Making it forward to a class static method worked. > If there is a simpler way, I'd love to make it simpler! I guess it's issue 6997.
	10 static List makeListFixedLength(List growableList)

	11 native "GrowableList_toFixedLength";

	12 }

OLD	NEW

« runtime/lib/growable_array.cc ('K') | « runtime/lib/growable_array.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | runtime/vm/bootstrap_natives.h » ('J')