components/policy/core/browser/configuration_policy_pref_store_unittest.cc - Issue 1348903007: Revert of Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/configuration_policy_pref_store_unittest.cc

Issue 1348903007: Revert of Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/browser/configuration_policy_handler_unittest.cc ('k') | components/policy/core/browser/url_blacklist_policy_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/browser/configuration_policy_pref_store_unittest.cc

diff --git a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc

index d4b2599f8840acb399ea0ca2863612ecabc5c8d5..c8a203669ed30ea2083e1d107cac6ac46f525661 100644

--- a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc

+++ b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc

@@ -16,7 +16,6 @@

#include "components/policy/core/common/policy_map.h"

#include "components/policy/core/common/policy_pref_names.h"

#include "components/policy/core/common/policy_service_impl.h"

-#include "components/policy/core/common/policy_types.h"

#include "testing/gmock/include/gmock/gmock.h"

// Note: this file should move to components/policy/core/browser, but the

@@ -56,8 +55,8 @@

in_value->Append(new base::StringValue("test1"));

in_value->Append(new base::StringValue("test2,"));

PolicyMap policy;

- policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD, in_value, nullptr);

+ policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY,

+ POLICY_SCOPE_USER, in_value, NULL);

UpdateProviderPolicy(policy);

const base::Value* value = NULL;

EXPECT_TRUE(store_->GetValue(kTestPref, &value));

@@ -84,7 +83,6 @@

policy.Set(kTestPolicy,

POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD,

new base::StringValue("http://chromium.org"),

NULL);

UpdateProviderPolicy(policy);

@@ -113,7 +111,6 @@

policy.Set(kTestPolicy,

POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD,

new base::FundamentalValue(false),

NULL);

UpdateProviderPolicy(policy);

@@ -128,7 +125,6 @@

policy.Set(kTestPolicy,

POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD,

new base::FundamentalValue(true),

NULL);

UpdateProviderPolicy(policy);

@@ -159,7 +155,6 @@

policy.Set(kTestPolicy,

POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD,

new base::FundamentalValue(2),

NULL);

UpdateProviderPolicy(policy);

@@ -196,7 +191,6 @@

policy.Set(kTestPolicy,

POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD,

new base::StringValue("http://www.chromium.org"),

NULL);

UpdateProviderPolicy(policy);