chrome/browser/extensions/api/storage/policy_value_store_unittest.cc - Issue 1348903007: Revert of Add source column to chrome://policy showing the origins of policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

Issue 1348903007: Revert of Add source column to chrome://policy showing the origins of policies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc ('k') | chrome/browser/extensions/api/storage/settings_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

diff --git a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

index 55bf7f2f59c0b5bb97ba219d2c6441ae36c8991f..d2ff1a83c067f79f4dd1ade350b3824eb5fc4d25 100644

--- a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

+++ b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

@@ -12,7 +12,6 @@

#include "base/message_loop/message_loop.h"

#include "components/policy/core/common/external_data_fetcher.h"

#include "components/policy/core/common/policy_map.h"

-#include "components/policy/core/common/policy_types.h"

#include "content/public/test/test_browser_thread.h"

#include "extensions/browser/api/storage/settings_observer.h"

#include "extensions/browser/value_store/leveldb_value_store.h"

@@ -121,10 +120,9 @@

policy::PolicyMap policies;

base::FundamentalValue expected(123);

policies.Set("must", policy::POLICY_LEVEL_MANDATORY,

- policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,

- expected.DeepCopy(), nullptr);

+ policy::POLICY_SCOPE_USER, expected.DeepCopy(), NULL);

policies.Set("may", policy::POLICY_LEVEL_RECOMMENDED,

- policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,

+ policy::POLICY_SCOPE_USER,

new base::FundamentalValue(456), NULL);

store_->SetCurrentPolicy(policies);

ValueStore::ReadResult result = store_->Get();

@@ -167,7 +165,7 @@

policy::PolicyMap policies;

policies.Set("aaa", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

- policy::POLICY_SOURCE_CLOUD, value.DeepCopy(), nullptr);

+ value.DeepCopy(), NULL);

store_->SetCurrentPolicy(policies);

loop_.RunUntilIdle();

Mock::VerifyAndClearExpectations(&observer_);

@@ -183,7 +181,7 @@

}

policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

- policy::POLICY_SOURCE_CLOUD, value.DeepCopy(), nullptr);

+ value.DeepCopy(), NULL);

store_->SetCurrentPolicy(policies);

loop_.RunUntilIdle();

Mock::VerifyAndClearExpectations(&observer_);

@@ -201,7 +199,7 @@

}

policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

- policy::POLICY_SOURCE_CLOUD, new_value.DeepCopy(), nullptr);

+ new_value.DeepCopy(), NULL);

store_->SetCurrentPolicy(policies);

loop_.RunUntilIdle();

Mock::VerifyAndClearExpectations(&observer_);