Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: webrtc/modules/audio_processing/echo_cancellation_impl.h

Issue 1348903004: Adding APM configuration in AEC dump. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/echo_cancellation_impl.h
diff --git a/webrtc/modules/audio_processing/echo_cancellation_impl.h b/webrtc/modules/audio_processing/echo_cancellation_impl.h
index 9c2b32c473bb6743d116a513b223aa23bcecb0a3..ba63eb54e71189560a5fa949c9cb90972f3499fc 100644
--- a/webrtc/modules/audio_processing/echo_cancellation_impl.h
+++ b/webrtc/modules/audio_processing/echo_cancellation_impl.h
@@ -37,20 +37,22 @@ class EchoCancellationImpl : public EchoCancellation,
int Initialize() override;
void SetExtraOptions(const Config& config) override;
+ SuppressionLevel suppression_level() const override;
peah-webrtc 2015/09/22 12:05:29 Is it really needed to change the public/private s
minyue-webrtc 2015/09/22 13:19:29 The problem is the instantiate of echo canceler in
peah-webrtc 2015/09/24 09:28:02 After a discussion together we agreed that to comp
peah-webrtc 2015/09/24 09:28:02 Acknowledged.
+ bool is_drift_compensation_enabled() const override;
+ bool is_delay_logging_enabled() const override;
+ bool is_extended_filter_enabled() const;
+
private:
// EchoCancellation implementation.
int Enable(bool enable) override;
int enable_drift_compensation(bool enable) override;
- bool is_drift_compensation_enabled() const override;
void set_stream_drift_samples(int drift) override;
int set_suppression_level(SuppressionLevel level) override;
- SuppressionLevel suppression_level() const override;
int enable_metrics(bool enable) override;
bool are_metrics_enabled() const override;
bool stream_has_echo() const override;
int GetMetrics(Metrics* metrics) override;
int enable_delay_logging(bool enable) override;
- bool is_delay_logging_enabled() const override;
int GetDelayMetrics(int* median, int* std) override;
int GetDelayMetrics(int* median,
int* std,

Powered by Google App Engine
This is Rietveld 408576698