Issue 13489007: Add webkit_trunk override in gclient to force bots to use blink for now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13489007: Add webkit_trunk override in gclient to force bots to use blink for now. (Closed)

Created:
7 years, 8 months ago by iannucci

Modified:
7 years, 8 months ago

Reviewers:
cmp

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Add webkit_trunk override in gclient to force bots to use blink for now. R=cmp@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192200

Patch Set 2 : fix nit #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	gclient.py	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cmp

lgtm with nit https://codereview.chromium.org/13489007/diff/1/gclient.py File gclient.py (right): https://codereview.chromium.org/13489007/diff/1/gclient.py#newcode192 gclient.py:192: if (self._custom_vars.get('webkit_trunk','') == nit: insert a ...

7 years, 8 months ago (2013-04-04 00:59:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r192200.

Expand Messages | Collapse Messages

Issue 13489007: Add webkit_trunk override in gclient to force bots to use blink for now. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix nit #

Messages