Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1348893002: Add app-as-shared-library flag in java_apk.gypi (Closed)

Created:
5 years, 3 months ago by michaelbai
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add app-as-shared-library flag in java_apk.gypi So it could be used for building apk BUG=532598 Committed: https://crrev.com/915104dacd3dca9594e9aadf0e196af387025d63 Cr-Commit-Position: refs/heads/master@{#349492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M build/android/gyp/package_resources.py View 2 chunks +6 lines, -0 lines 0 comments Download
M build/android/gyp/process_resources.py View 2 chunks +6 lines, -0 lines 0 comments Download
M build/android/package_resources_action.gypi View 3 chunks +8 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
michaelbai
5 years, 3 months ago (2015-09-16 19:54:19 UTC) #2
Yaron
On 2015/09/16 19:54:19, michaelbai wrote: drive-by: please add GN support as well. we're trying to ...
5 years, 3 months ago (2015-09-16 20:57:37 UTC) #3
michaelbai
On 2015/09/16 20:57:37, Yaron wrote: > On 2015/09/16 19:54:19, michaelbai wrote: > > drive-by: please ...
5 years, 3 months ago (2015-09-16 21:01:30 UTC) #4
Yaron
On 2015/09/16 21:01:30, michaelbai wrote: > On 2015/09/16 20:57:37, Yaron wrote: > > On 2015/09/16 ...
5 years, 3 months ago (2015-09-16 21:16:26 UTC) #5
jbudorick
On 2015/09/16 at 21:16:26, yfriedman wrote: > On 2015/09/16 21:01:30, michaelbai wrote: > > On ...
5 years, 3 months ago (2015-09-16 21:19:46 UTC) #6
michaelbai
On 2015/09/16 21:16:26, Yaron wrote: > On 2015/09/16 21:01:30, michaelbai wrote: > > On 2015/09/16 ...
5 years, 3 months ago (2015-09-16 21:21:47 UTC) #7
michaelbai
On 2015/09/16 21:16:26, Yaron wrote: > On 2015/09/16 21:01:30, michaelbai wrote: > > On 2015/09/16 ...
5 years, 3 months ago (2015-09-16 21:21:49 UTC) #8
Torne
On 2015/09/16 21:21:49, michaelbai wrote: > On 2015/09/16 21:16:26, Yaron wrote: > > On 2015/09/16 ...
5 years, 3 months ago (2015-09-17 10:28:54 UTC) #9
Yaron
On 2015/09/17 10:28:54, Torne wrote: > On 2015/09/16 21:21:49, michaelbai wrote: > > On 2015/09/16 ...
5 years, 3 months ago (2015-09-17 12:31:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348893002/1
5 years, 3 months ago (2015-09-17 19:18:33 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 20:55:52 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 20:56:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/915104dacd3dca9594e9aadf0e196af387025d63
Cr-Commit-Position: refs/heads/master@{#349492}

Powered by Google App Engine
This is Rietveld 408576698