Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1348883003: Roll mini_chromium to 302e4e7d9aa0a8d39ad62b193a4c8a8357ad9d0c (Closed)

Created:
5 years, 3 months ago by scottmg
Modified:
5 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Roll mini_chromium to 302e4e7d9aa0a8d39ad62b193a4c8a8357ad9d0c Pulls in "win: Don't omit frame pointers". TBR=mark@chromium.org BUG=crashpad:50 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/bf94f98eccec90bd8700ae23100dec310f56b612

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
5 years, 3 months ago (2015-09-16 21:34:59 UTC) #1
scottmg
Committed patchset #1 (id:1) manually as bf94f98eccec90bd8700ae23100dec310f56b612 (presubmit successful).
5 years, 3 months ago (2015-09-16 21:35:33 UTC) #2
Mark Mentovai
LGTM
5 years, 3 months ago (2015-09-16 21:36:42 UTC) #3
scottmg
Yay, all green: https://build.chromium.org/p/client.crashpad/console. Hopefully we get an x86 build slave soon and I can ...
5 years, 3 months ago (2015-09-16 21:43:37 UTC) #4
Mark Mentovai
5 years, 3 months ago (2015-09-16 21:47:15 UTC) #5
Message was sent while issue was closed. 
Congratulations!

Powered by Google App Engine
This is Rietveld 408576698