Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1348883002:
Font cache stress test. (Closed)
DescriptionFont cache stress test.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/1052f51a7da744b8fd8b7d89e0a3a13725c3e6b2
Patch Set 1 #Patch Set 2 : make a nanobench #
Total comments: 4
Patch Set 3 : clean up and parameterize #
Total comments: 1
Patch Set 4 : fix static function name #Patch Set 5 : fix ms comile bug #Patch Set 6 : fix more ms compiler problems #Patch Set 7 : fix format string problem #Messages
Total messages: 28 (12 generated)
herb@google.com changed reviewers: + mtklein@google.com
I'm starting making stress tests for the lru part of the font cache. Any ideas for others or for stress tests for an individual SkGlyphCache?
We don't seem to be asserting anything. It looks like this is meant only for timing / profiling? Why don't we make this a bench?
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348883002/20001
Changed to nanobench.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
https://codereview.chromium.org/1348883002/diff/20001/bench/SkGlyphCacheBench... File bench/SkGlyphCacheBench.cpp (right): https://codereview.chromium.org/1348883002/diff/20001/bench/SkGlyphCacheBench... bench/SkGlyphCacheBench.cpp:48: class SkGlyphCacheStressTest : public Benchmark { For non-rendering benchmarks like these, typically we'll add something like: bool isSuitableFor(Backend backend) override { return backend == kNonRendering_Backend; } and not name the SkCanvas* arugment to onDraw(). That way it runs once instead of against umptillion SkCanvas backends that make no difference. https://codereview.chromium.org/1348883002/diff/20001/bench/SkGlyphCacheBench... bench/SkGlyphCacheBench.cpp:53: SkGraphics::SetFontCacheLimit(256 * 1024); Might be nice to set this back to whatever it started as when we're done?
PTAL https://codereview.chromium.org/1348883002/diff/20001/bench/SkGlyphCacheBench... File bench/SkGlyphCacheBench.cpp (right): https://codereview.chromium.org/1348883002/diff/20001/bench/SkGlyphCacheBench... bench/SkGlyphCacheBench.cpp:48: class SkGlyphCacheStressTest : public Benchmark { On 2015/09/16 22:33:51, mtklein wrote: > For non-rendering benchmarks like these, typically we'll add something like: > bool isSuitableFor(Backend backend) override { return backend == > kNonRendering_Backend; } > and not name the SkCanvas* arugment to onDraw(). > > That way it runs once instead of against umptillion SkCanvas backends that make > no difference. Done. https://codereview.chromium.org/1348883002/diff/20001/bench/SkGlyphCacheBench... bench/SkGlyphCacheBench.cpp:53: SkGraphics::SetFontCacheLimit(256 * 1024); On 2015/09/16 22:33:51, mtklein wrote: > Might be nice to set this back to whatever it started as when we're done? Done.
lgtm https://codereview.chromium.org/1348883002/diff/40001/bench/SkGlyphCacheBench... File bench/SkGlyphCacheBench.cpp (right): https://codereview.chromium.org/1348883002/diff/40001/bench/SkGlyphCacheBench... bench/SkGlyphCacheBench.cpp:20: static void DoFontStuff(SkPaint* paint) { do_font_stuff
The CQ bit was checked by herb@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com Link to the patchset: https://codereview.chromium.org/1348883002/#ps60001 (title: "fix static function name")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348883002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348883002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348883002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348883002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-...)
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348883002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348883002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by herb@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com Link to the patchset: https://codereview.chromium.org/1348883002/#ps120001 (title: "fix format string problem")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348883002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348883002/120001
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://skia.googlesource.com/skia/+/1052f51a7da744b8fd8b7d89e0a3a13725c3e6b2 |
