content/browser/renderer_host/native_web_keyboard_event_mac.mm - Issue 1348843002: Revert of [KeyEvent Mac] Move WebInputEventFactory into chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/native_web_keyboard_event_mac.mm

Issue 1348843002: Revert of [KeyEvent Mac] Move WebInputEventFactory into chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/web_input_event_util.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/native_web_keyboard_event_mac.mm

diff --git a/content/browser/renderer_host/native_web_keyboard_event_mac.mm b/content/browser/renderer_host/native_web_keyboard_event_mac.mm

index beed79ae54f8d8cffb5bf62f7c262f5b27dc32b0..76c5c1006bfcda2dad993fb71de54de13a7f08ec 100644

--- a/content/browser/renderer_host/native_web_keyboard_event_mac.mm

+++ b/content/browser/renderer_host/native_web_keyboard_event_mac.mm

@@ -6,8 +6,10 @@

#import <AppKit/AppKit.h>

-#include "content/browser/renderer_host/input/web_input_event_builders_mac.h"

+#include "third_party/WebKit/public/web/mac/WebInputEventFactory.h"

#include "ui/events/event.h"

+using blink::WebInputEventFactory;

namespace content {

@@ -17,9 +19,10 @@

}

NativeWebKeyboardEvent::NativeWebKeyboardEvent(gfx::NativeEvent native_event)

- : WebKeyboardEvent(WebKeyboardEventBuilder::Build(native_event)),

+ : WebKeyboardEvent(WebInputEventFactory::keyboardEvent(native_event)),

os_event([native_event retain]),

- skip_in_browser(false) {}

+ skip_in_browser(false) {

NativeWebKeyboardEvent::NativeWebKeyboardEvent(const ui::KeyEvent& key_event)

: NativeWebKeyboardEvent(key_event.native_event()) {