Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1348833003: Fix NTP thumbnail generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bug and clean up code. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index df4cade6a9f985f7d296cc392c7a31c3be86e90b..6cc8a80b5ca970071798ac4c6277713aee35fcfe 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -945,10 +945,7 @@ void RenderWidgetHostViewMac::WasOccluded() {
// Note that the following call to WasHidden() can trigger thumbnail
// generation on behalf of the NTP, and that cannot succeed if the browser
// compositor view has been suspended. Therefore these two statements must
- // occur in this specific order. However, because thumbnail generation is
- // asychronous, that operation won't run before SuspendBrowserCompositorView()
- // completes. As a result you won't get a thumbnail for the page unless you
- // happen to switch back to it. See http://crbug.com/530707 .
+ // occur in this specific order.
render_widget_host_->WasHidden();
SuspendBrowserCompositorView();
}

Powered by Google App Engine
This is Rietveld 408576698