Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9385)

Unified Diff: chrome/browser/thumbnails/simple_thumbnail_crop.cc

Issue 1348833003: Fix NTP thumbnail generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nit. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/thumbnails/simple_thumbnail_crop.cc
diff --git a/chrome/browser/thumbnails/simple_thumbnail_crop.cc b/chrome/browser/thumbnails/simple_thumbnail_crop.cc
index debdfa42936de3e24bd158a47e6c5ce552d6b9f1..5af2ae9e927df93a294624230060582b75052b98 100644
--- a/chrome/browser/thumbnails/simple_thumbnail_crop.cc
+++ b/chrome/browser/thumbnails/simple_thumbnail_crop.cc
@@ -45,16 +45,19 @@ void SimpleThumbnailCrop::ProcessBitmap(
if (bitmap.isNull() || bitmap.empty())
return;
+ ClipResult clip_result;
SkBitmap thumbnail = CreateThumbnail(
bitmap,
ComputeTargetSizeAtMaximumScale(target_size_),
- &context->clip_result);
-
- context->score.boring_score = color_utils::CalculateBoringScore(thumbnail);
- context->score.good_clipping =
- (context->clip_result == CLIP_RESULT_WIDER_THAN_TALL ||
- context->clip_result == CLIP_RESULT_TALLER_THAN_WIDE ||
- context->clip_result == CLIP_RESULT_NOT_CLIPPED);
+ &clip_result);
+
+ context->SetBoringScore(color_utils::CalculateBoringScore(thumbnail));
+ context->set_clip_result(clip_result);
+ bool good_clipping =
+ (clip_result == CLIP_RESULT_WIDER_THAN_TALL ||
+ clip_result == CLIP_RESULT_TALLER_THAN_WIDE ||
+ clip_result == CLIP_RESULT_NOT_CLIPPED);
+ context->SetGoodClipping(good_clipping);
callback.Run(*context.get(), thumbnail);
}

Powered by Google App Engine
This is Rietveld 408576698