chrome/browser/thumbnails/thumbnailing_context.cc - Issue 1348833003: Fix NTP thumbnail generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/thumbnails/thumbnailing_context.cc

Issue 1348833003: Fix NTP thumbnail generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Watch for destruction of web_contents. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/thumbnails/thumbnailing_context.cc

diff --git a/chrome/browser/thumbnails/thumbnailing_context.cc b/chrome/browser/thumbnails/thumbnailing_context.cc

index 04765e640550aaadb791ecf188739fa49b4c98ad..5a5ccb9be5b8209cd6d7f4c944bcfe12c9052ef1 100644

--- a/chrome/browser/thumbnails/thumbnailing_context.cc

+++ b/chrome/browser/thumbnails/thumbnailing_context.cc

@@ -12,7 +12,8 @@ namespace thumbnails {

ThumbnailingContext::ThumbnailingContext(content::WebContents* web_contents,

ThumbnailService* receiving_service,

bool load_interrupted)

- : service(receiving_service),

+ : content::WebContentsObserver(web_contents),

+ service(receiving_service),

url(web_contents->GetURL()),

clip_result(CLIP_RESULT_UNPROCESSED) {

score.at_top =