Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13488014: Translate: Adding a flag to enable "alpha language" translation (Closed)

Created:
7 years, 8 months ago by Takashi Toyoshima
Modified:
7 years, 8 months ago
Reviewers:
MAD
CC:
chromium-reviews
Visibility:
Public.

Description

Translate: Adding a flag to enable "alpha language" translation BUG=226895 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192827

Patch Set 1 #

Patch Set 2 : about:flags #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : use AppendQueryParameter #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 2 3 3 chunks +23 lines, -5 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Takashi Toyoshima
Hi mad@, After discussion with Translate team at b/8546402, we are going to add a ...
7 years, 8 months ago (2013-04-05 10:54:01 UTC) #1
MAD
Looks good but I have one request... Thanks! BYE MAD https://codereview.chromium.org/13488014/diff/5001/chrome/browser/translate/translate_manager.cc File chrome/browser/translate/translate_manager.cc (right): https://codereview.chromium.org/13488014/diff/5001/chrome/browser/translate/translate_manager.cc#newcode145 ...
7 years, 8 months ago (2013-04-05 14:18:34 UTC) #2
Takashi Toyoshima
https://codereview.chromium.org/13488014/diff/5001/chrome/browser/translate/translate_manager.cc File chrome/browser/translate/translate_manager.cc (right): https://codereview.chromium.org/13488014/diff/5001/chrome/browser/translate/translate_manager.cc#newcode145 chrome/browser/translate/translate_manager.cc:145: "?client=chrome&cb=sl&hl=%s%s"; Agreed. I'll apply AppendQueryParameter on modifying kLanguageListFetchURL in ...
7 years, 8 months ago (2013-04-08 03:39:05 UTC) #3
MAD
Excellent, thanks! LGTM... BYE MAD
7 years, 8 months ago (2013-04-08 14:21:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/13488014/18001
7 years, 8 months ago (2013-04-08 14:38:04 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 14:46:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/13488014/18001
7 years, 8 months ago (2013-04-08 14:53:01 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 14:57:47 UTC) #8
Takashi Toyoshima
7 years, 8 months ago (2013-04-08 16:20:02 UTC) #9
Message was sent while issue was closed. 
Committed patchset #5 manually as r192827 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698