Remove application locale cache in autofill code.

chrome/browser/webdata/autofill_profile_syncable_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/webdata/autofill_profile_syncable_service.h"
 
 #include "base/guid.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
+#include "chrome/browser/browser_process.h"
 #include "components/autofill/browser/autofill_profile.h"
 #include "components/autofill/browser/form_group.h"
 #include "components/webdata/autofill/autofill_table.h"
 #include "components/webdata/autofill/autofill_webdata_service.h"
 #include "components/webdata/common/web_database.h"
 #include "content/public/browser/browser_thread.h"
 #include "sync/api/sync_error.h"
 #include "sync/api/sync_error_factory.h"
 #include "sync/protocol/sync.pb.h"
 
@@ skipping 524 matching lines @@
     }
   }
   if (changed)
     autofill_profile->SetRawMultiInfo(field_type, values);
   return changed;
 }
 
 bool AutofillProfileSyncableService::MergeProfile(
     const AutofillProfile& merge_from,
     AutofillProfile* merge_into) {
-  merge_into->OverwriteWithOrAddTo(merge_from);
+  merge_into->OverwriteWithOrAddTo(
+      merge_from, g_browser_process->GetApplicationLocale());

[Ilya Sherman, 2013/04/04 04:27:38]

I'm pretty sure that AutofillProfileSyncableService::MergeProfile() is called on
the DB thread, from which it isn't safe to access g_browser_process.

[jam, 2013/04/04 17:58:12]

thanks, fixed.

   return (merge_into->Compare(merge_from) != 0);
 }
 
 AutofillTable* AutofillProfileSyncableService::GetAutofillTable() const {
   return AutofillTable::FromWebDatabase(web_data_service_->GetDatabase());
 }
 
 AutofillProfileSyncableService::DataBundle::DataBundle() {}
 
 AutofillProfileSyncableService::DataBundle::~DataBundle() {}