Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: Source/core/loader/FormSubmission.cpp

Issue 134873010: Removed 'String::append' from some of the blink source. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed 'String::append' from some of the blink source. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/FormSubmission.cpp
diff --git a/Source/core/loader/FormSubmission.cpp b/Source/core/loader/FormSubmission.cpp
index 178a996bc763acb3abfd5f022db45241dbde6af4..2ce0991701a4024f09b3c1426fbb9179230821b7 100644
--- a/Source/core/loader/FormSubmission.cpp
+++ b/Source/core/loader/FormSubmission.cpp
@@ -75,8 +75,8 @@ static void appendMailtoPostFormDataToURL(KURL& url, const FormData& data, const
String query = url.query();
if (!query.isEmpty())
- query.append('&');
- query.append(body);
+ query = query + '&';
+ query = query + body;
abarth-chromium 2014/01/15 17:50:18 Can we use StringBuilder here instead?
Sunil Ratnu 2014/01/16 05:49:56 Thanks abarth! Yes we can use StringBuilder here
url.setQuery(query);
}
« no previous file with comments | « Source/core/inspector/InspectorFileSystemAgent.cpp ('k') | Source/modules/websockets/WebSocketHandshake.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698