Removed 'String::append' from some of the blink source.

Removed 'String::append' from some of the blink source.

BUG=268281
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165246

[Sunil Ratnu, 2014-01-15 08:15:49]

Please have a look.

[abarth-chromium, 2014-01-15 17:50:18]

lgtm

https://codereview.chromium.org/134873010/diff/30001/Source/core/loader/FormS...
File Source/core/loader/FormSubmission.cpp (right):

https://codereview.chromium.org/134873010/diff/30001/Source/core/loader/FormS...
Source/core/loader/FormSubmission.cpp:79: query = query + body;
Can we use StringBuilder here instead?

[Sunil Ratnu, 2014-01-16 05:49:55]

https://codereview.chromium.org/134873010/diff/30001/Source/core/loader/FormS...
File Source/core/loader/FormSubmission.cpp (right):

https://codereview.chromium.org/134873010/diff/30001/Source/core/loader/FormS...
Source/core/loader/FormSubmission.cpp:79: query = query + body;
On 2014/01/15 17:50:18, abarth wrote:
> Can we use StringBuilder here instead?

Thanks abarth!

Yes we can use StringBuilder here like this:

StringBuilder query;
query.append(url.query());
if (!query.isEmpty())
    query.append('&');
query.append(body);
url.setQuery(query.toString());

If that is fine with you, I will change it this way.

[abarth-chromium, 2014-01-16 07:02:24]

On 2014/01/16 05:49:55, sunil.ratnu wrote:
>
https://codereview.chromium.org/134873010/diff/30001/Source/core/loader/FormS...
> File Source/core/loader/FormSubmission.cpp (right):
> 
>
https://codereview.chromium.org/134873010/diff/30001/Source/core/loader/FormS...
> Source/core/loader/FormSubmission.cpp:79: query = query + body;
> On 2014/01/15 17:50:18, abarth wrote:
> > Can we use StringBuilder here instead?
> 
> Thanks abarth!
> 
> Yes we can use StringBuilder here like this:
> 
> StringBuilder query;
> query.append(url.query());
> if (!query.isEmpty())
>     query.append('&');
> query.append(body);
> url.setQuery(query.toString());
> 
> If that is fine with you, I will change it this way.

Yep.  Looks good.

[Sunil Ratnu, 2014-01-16 08:25:37]

On 2014/01/16 07:02:24, abarth wrote:
> On 2014/01/16 05:49:55, sunil.ratnu wrote:
> >
>
https://codereview.chromium.org/134873010/diff/30001/Source/core/loader/FormS...
> > File Source/core/loader/FormSubmission.cpp (right):
> > 
> >
>
https://codereview.chromium.org/134873010/diff/30001/Source/core/loader/FormS...
> > Source/core/loader/FormSubmission.cpp:79: query = query + body;
> > On 2014/01/15 17:50:18, abarth wrote:
> > > Can we use StringBuilder here instead?
> > 
> > Thanks abarth!
> > 
> > Yes we can use StringBuilder here like this:
> > 
> > StringBuilder query;
> > query.append(url.query());
> > if (!query.isEmpty())
> >     query.append('&');
> > query.append(body);
> > url.setQuery(query.toString());
> > 
> > If that is fine with you, I will change it this way.
> 
> Yep.  Looks good.

Incorporated review comments.

[commit-bot: I haz the power, 2014-01-16 10:01:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/134873010/130001

[commit-bot: I haz the power, 2014-01-16 10:35:14]

Retried try job too often on linux_blink for step(s) wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-16 19:32:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/134873010/130001

[commit-bot: I haz the power, 2014-01-16 19:44:33]

Change committed as 165246