content/browser/download/download_item_impl.cc - Issue 1348683003: enable download protection on CrOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl.cc

Issue 1348683003: enable download protection on CrOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit change NULL to nullptr Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_item_impl.cc

diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc

index 1e5d53aef0060beec28545dbea5d5b0dc3a64969..42c0f778d27b1e9870778bf74eca8dff68291af1 100644

--- a/content/browser/download/download_item_impl.cc

+++ b/content/browser/download/download_item_impl.cc

@@ -666,7 +666,7 @@ void DownloadItemImpl::DeleteFile(const base::Callback<void(bool)>& callback) {

}

bool DownloadItemImpl::IsDangerous() const {

-#if defined(OS_WIN) || defined(OS_MACOSX)

+#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_CHROMEOS)

// TODO(noelutz): At this point only the windows views and OSX UI supports

Nathan Parker 2015/10/21 21:10:39 Comment needs updating, or removing.

// warnings based on dangerous content.

return (danger_type_ == DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE ||