Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1348663002: Move pref_proxy_config_tracker_impl_unittest to components/proxy_config (Closed)

Created:
5 years, 3 months ago by Abhishek
Modified:
5 years, 3 months ago
Reviewers:
droger, stevenjb, eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, r.kasibhatla, Jitu( very slow this week)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move pref_proxy_config_tracker_impl_unittest to components/proxy_config BUG=516714 Committed: https://crrev.com/31c6dc34af88da14a006415cc87af9e35ba53725 Cr-Commit-Position: refs/heads/master@{#349363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -365 lines) Patch
D chrome/browser/net/pref_proxy_config_tracker_impl_unittest.cc View 1 chunk +0 lines, -365 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/proxy_config/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/proxy_config/pref_proxy_config_tracker_impl_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Abhishek
PTAL!
5 years, 3 months ago (2015-09-16 11:24:52 UTC) #2
droger
lgtm
5 years, 3 months ago (2015-09-16 11:32:43 UTC) #3
Abhishek
+stevenjb: components/proxy_config +eroman: c/b/n/pref_proxy_config_tracker_impl_unittest.cc
5 years, 3 months ago (2015-09-16 11:41:42 UTC) #5
stevenjb
Thanks! lgtm
5 years, 3 months ago (2015-09-16 17:38:11 UTC) #6
eroman
5 years, 3 months ago (2015-09-16 20:31:43 UTC) #7
eroman
lgtm
5 years, 3 months ago (2015-09-16 20:31:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348663002/1
5 years, 3 months ago (2015-09-17 05:29:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 07:10:49 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 07:11:41 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/31c6dc34af88da14a006415cc87af9e35ba53725
Cr-Commit-Position: refs/heads/master@{#349363}

Powered by Google App Engine
This is Rietveld 408576698