Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1348653003: [test] Fix cctest path separators on Windows (Closed)

Created:
5 years, 3 months ago by Jakob Kummerow
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com, domenic
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix cctest path separators on Windows Now run-tests.py understands "suite/foo/bar" with forward slashes for command-line test selection on all test suites on all platforms. Previously, file-based suites like mjsunit also accepted "mjsunit/foo\bar"; that behavior is sacrificed here in favor of unification. For the cctest suite, OTOH, it wasn't possible on Windows to select specific tests at all. Committed: https://crrev.com/b36cfdb39ae648b49a1396c4f669df9b1f57996c Cr-Commit-Position: refs/heads/master@{#30794}

Patch Set 1 #

Patch Set 2 : fix top-level tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M test/intl/testcfg.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M test/message/testcfg.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/testcfg.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M test/mozilla/testcfg.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M test/test262-es6/testcfg.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M test/test262/testcfg.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M test/webkit/testcfg.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M tools/testrunner/local/testsuite.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
Jakob Kummerow
PTAL. The fix for cctest is in testsuite.py; all the testcfg.py changes are needed to ...
5 years, 3 months ago (2015-09-16 13:29:59 UTC) #2
Michael Achenbach
lg-tm for the motivation. But some stuff seems to not work as expected. E.g. this: ...
5 years, 3 months ago (2015-09-17 08:40:57 UTC) #3
Jakob Kummerow
Thanks. What tripped me up was that "".split("x") == [""], as opposed to [], which ...
5 years, 3 months ago (2015-09-17 09:24:47 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348653003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348653003/20001
5 years, 3 months ago (2015-09-17 10:45:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 11:10:17 UTC) #8
Michael Achenbach
LGTM - thanks for that patch!
5 years, 3 months ago (2015-09-17 11:12:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348653003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348653003/20001
5 years, 3 months ago (2015-09-17 11:20:40 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-17 11:24:01 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b36cfdb39ae648b49a1396c4f669df9b1f57996c Cr-Commit-Position: refs/heads/master@{#30794}
5 years, 3 months ago (2015-09-17 11:24:19 UTC) #14
Jakob Kummerow
5 years, 3 months ago (2015-09-17 11:59:53 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1349163002/ by jkummerow@chromium.org.

The reason for reverting is: mozilla tests are failing on Windows.

Powered by Google App Engine
This is Rietveld 408576698