Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1348633002: gn help switches doc fixup (Closed)

Created:
5 years, 3 months ago by Mostyn Bramley-Moore
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina, nodir, Bons
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn help switches doc fixup GN docs refer to "gn help" for common command-line switches in a couple of places, but that only shows the top level help. The reference should of course be "gn help switches". Committed: https://crrev.com/56807c6cb383140af0c03da8f6731d77785d7160 Cr-Commit-Position: refs/heads/master@{#349215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/gn/command_gen.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/docs/reference.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Mostyn Bramley-Moore
@brettw: here's another small doc fixup.
5 years, 3 months ago (2015-09-16 07:37:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348633002/1
5 years, 3 months ago (2015-09-16 07:38:06 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/113569)
5 years, 3 months ago (2015-09-16 07:48:05 UTC) #6
brettw
LGTM, thanks!
5 years, 3 months ago (2015-09-16 20:25:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348633002/1
5 years, 3 months ago (2015-09-16 20:32:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 20:45:00 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 20:45:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56807c6cb383140af0c03da8f6731d77785d7160
Cr-Commit-Position: refs/heads/master@{#349215}

Powered by Google App Engine
This is Rietveld 408576698