Track when profiles are last used.

Track when profiles are last used.

This will allow use to ignore profiles unused for a certain length of time (likely 28 days) when calculating statistics on number of profiles, number of signed-in profiles, etc.

BUG=295817
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244760

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245229

[bcwhite, 2014-01-10 22:08:43]

+OWNER  :-)

[noms (inactive), 2014-01-13 16:39:44]

https://codereview.chromium.org/134863002/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_info_cache.h (right):

https://codereview.chromium.org/134863002/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_info_cache.h:60: virtual base::Time
GetProfileActive(size_t index) const OVERRIDE;
I think the function should end in "AtIndex", to be consistent. Maybe
GetLastActiveTimeOfProfileAtIndex? Then the preference key should probably also
be called last_active_time.

https://codereview.chromium.org/134863002/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_info_cache.h:92: void SetProfileActive(size_t
index);
Same comment as above

[bcwhite, 2014-01-13 17:05:38]

added missing AtIndex to function names

[bcwhite, 2014-01-13 17:05:48]

https://codereview.chromium.org/134863002/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_info_cache.h (right):

https://codereview.chromium.org/134863002/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_info_cache.h:60: virtual base::Time
GetProfileActive(size_t index) const OVERRIDE;
On 2014/01/13 16:39:44, Monica Dinculescu wrote:
> I think the function should end in "AtIndex", to be consistent. Maybe
> GetLastActiveTimeOfProfileAtIndex? Then the preference key should probably
also
> be called last_active_time.

Done.

https://codereview.chromium.org/134863002/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_info_cache.h:92: void SetProfileActive(size_t
index);
On 2014/01/13 16:39:44, Monica Dinculescu wrote:
> Same comment as above

Done.

[bcwhite, 2014-01-13 17:09:46]

removed unneeded braces

[bcwhite, 2014-01-13 17:42:57]

fixed unittest

[bcwhite, 2014-01-13 19:06:06]

added 'Time' to new functions

[noms (inactive), 2014-01-13 20:29:25]

lgtm

[commit-bot: I haz the power, 2014-01-13 21:05:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/134863002/360002

[commit-bot: I haz the power, 2014-01-14 00:31:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/134863002/360002

[commit-bot: I haz the power, 2014-01-14 07:21:37]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-14 16:11:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/134863002/360002

[commit-bot: I haz the power, 2014-01-14 17:41:26]

Change committed as 244760

[commit-bot: I haz the power, 2014-01-16 13:55:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/134863002/750001

[commit-bot: I haz the power, 2014-01-16 17:27:26]

Change committed as 245229