Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1348533006: Make use of md5_check within finalize_apk.py (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@md5-check-with-outputs
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make use of md5_check within finalize_apk.py This stops the _incremental.apk from being re-finalized over and over during normal development. BUG=533442 Committed: https://crrev.com/1ed522607cd798f60c6120ed5f97b85e6a233f47 Cr-Commit-Position: refs/heads/master@{#350732}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M build/android/gyp/finalize_apk.py View 1 3 chunks +23 lines, -8 lines 0 comments Download

Depends on Patchset:

Issue 1356873003 Patch 60001

Messages

Total messages: 9 (4 generated)
pkotwicz
lgtm
5 years, 3 months ago (2015-09-24 17:37:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348533006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348533006/20001
5 years, 3 months ago (2015-09-24 18:11:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348533006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348533006/20001
5 years, 2 months ago (2015-09-25 01:04:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-25 01:15:56 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 01:16:49 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1ed522607cd798f60c6120ed5f97b85e6a233f47
Cr-Commit-Position: refs/heads/master@{#350732}

Powered by Google App Engine
This is Rietveld 408576698