Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1348533005: Reland of Make profiler no frame region detection code more robust [ia86/x64] (Closed)

Created:
5 years, 3 months ago by alph
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, yurys
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Make profiler no frame region detection code more robust [ia86/x64] Upon collection of the stack trace if the current PC falls into the frame building code, the top frame might be in a non-consistent state. That leads to some of the frames could be missing from the stack trace. The patch makes it check instructions under current PC and if they look like the frame setup/destroy code, it skips the entire sample. Support for x86/x64 CG_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_msan_rel BUG=chromium:529931 LOG=N Committed: https://crrev.com/4962bbb1356ba7465f88c8ed74310159750035b9 Cr-Commit-Position: refs/heads/master@{#30841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -3 lines) Patch
M src/sampler.cc View 4 chunks +84 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348533005/1
5 years, 3 months ago (2015-09-17 21:14:54 UTC) #2
alph
ptal. This version should have the simulator failures fixed.
5 years, 3 months ago (2015-09-17 21:29:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 21:41:42 UTC) #6
yurys
lgtm
5 years, 3 months ago (2015-09-17 21:44:37 UTC) #7
Benedikt Meurer
There still seem to MSAN issues left.
5 years, 3 months ago (2015-09-18 01:55:48 UTC) #8
alph
On 2015/09/18 01:55:48, Benedikt Meurer wrote: > There still seem to MSAN issues left. This ...
5 years, 3 months ago (2015-09-18 03:37:47 UTC) #9
Benedikt Meurer
On 2015/09/18 03:37:47, alph wrote: > On 2015/09/18 01:55:48, Benedikt Meurer wrote: > > There ...
5 years, 3 months ago (2015-09-20 16:15:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348533005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348533005/1
5 years, 3 months ago (2015-09-20 16:15:20 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-20 16:40:25 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-20 16:40:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4962bbb1356ba7465f88c8ed74310159750035b9
Cr-Commit-Position: refs/heads/master@{#30841}

Powered by Google App Engine
This is Rietveld 408576698