Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1348533003: Fix three Windows base_unittests to not require admin (Closed)

Created:
5 years, 3 months ago by brucedawson
Modified:
5 years, 3 months ago
CC:
chromium-reviews, Will Harris
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix three Windows base_unittests to not require admin These three base_unittests tests fail when run as non-admin on Windows if %temp% is set to a non-standard location such as d:\src\temp: - FileTest.GetInfoForDirectory - FileUtilTest.FileEnumeratorTest - FileUtilTest.NormalizeFilePathReparsePoints They all fail because the default user doesn't have enough permissions to open the directories with FILE_ALL_ACCESS. Asking for fewer permissions allows the tests to pass regardless of user-type and %temp% location. R=rvargas@chromium.org BUG=533018 Committed: https://crrev.com/35b35d85da7746865bc66f3dee35487567e0a356 Cr-Commit-Position: refs/heads/master@{#349485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/files/file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
brucedawson
If there is a fundamental reason why these tests are *supposed* to require admin I ...
5 years, 3 months ago (2015-09-17 17:50:13 UTC) #1
rvargas (doing something else)
On 2015/09/17 17:50:13, brucedawson wrote: > If there is a fundamental reason why these tests ...
5 years, 3 months ago (2015-09-17 20:01:52 UTC) #2
brucedawson
Yep, I discovered after uploading this that the default temp location works fine. I'll update ...
5 years, 3 months ago (2015-09-17 20:08:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348533003/1
5 years, 3 months ago (2015-09-17 20:11:13 UTC) #5
rvargas (doing something else)
On 2015/09/17 20:08:44, brucedawson wrote: > Yep, I discovered after uploading this that the default ...
5 years, 3 months ago (2015-09-17 20:22:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 20:31:06 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 20:31:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35b35d85da7746865bc66f3dee35487567e0a356
Cr-Commit-Position: refs/heads/master@{#349485}

Powered by Google App Engine
This is Rietveld 408576698