Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/public/cpp/system/tests/macros_unittest.cc

Issue 1348493002: Add fnl build target (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/toolchain/fnl/BUILD.gn ('K') | « mojo/public/BUILD.gn ('k') | mojo/tools/embed/rules.gni » ('j') | mojo/tools/mojob.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/system/tests/macros_unittest.cc
diff --git a/mojo/public/cpp/system/tests/macros_unittest.cc b/mojo/public/cpp/system/tests/macros_unittest.cc
index 72a9b242776e52a385c91f04f7be3625ade4d5a4..b016dd12b800cb73cb83bf2bd4a9b38b3604754a 100644
--- a/mojo/public/cpp/system/tests/macros_unittest.cc
+++ b/mojo/public/cpp/system/tests/macros_unittest.cc
@@ -84,6 +84,9 @@ TEST(MacrosCppTest, ArraySize) {
// the size of the type of the local and not the values itself.
MOJO_ALLOW_UNUSED_LOCAL(local_array);
EXPECT_EQ(4u, MOJO_ARRAYSIZE(local_array));
+
+ // Prevent gcc unneeded-internal-declaration warning
viettrungluu 2015/09/15 23:48:22 nit: period at the end of the comment.
cdotstout 2015/09/16 22:01:00 Done.
+ MOJO_ALLOW_UNUSED_LOCAL(kGlobalArray);
viettrungluu 2015/09/15 23:48:22 "LOCAL". Sigh. <shrug>
cdotstout 2015/09/16 22:01:00 Acknowledged.
}
// Note: MSVS is very strict (and arguably buggy) about warnings for classes
« build/toolchain/fnl/BUILD.gn ('K') | « mojo/public/BUILD.gn ('k') | mojo/tools/embed/rules.gni » ('j') | mojo/tools/mojob.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698